From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23135 invoked by alias); 8 Nov 2017 19:08:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23126 invoked by uid 89); 8 Nov 2017 19:08:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=learn X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.146.7) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Nov 2017 19:08:46 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 0C5E88D3E for ; Wed, 8 Nov 2017 13:08:45 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CViPersf6c72gCViPep1Xr; Wed, 08 Nov 2017 13:08:45 -0600 Received: from 71-218-90-63.hlrn.qwest.net ([71.218.90.63]:52892 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eCViO-0019Ic-QA; Wed, 08 Nov 2017 13:08:44 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Simplify the psymbol hash function References: <20171104161356.17565-1-tom@tromey.com> <20171104161356.17565-3-tom@tromey.com> <92a5383c-5fd0-baee-fbaa-977669a3c613@redhat.com> <2981cbf6-e953-3f07-70d8-eac3ac78145e@redhat.com> Date: Wed, 08 Nov 2017 19:08:00 -0000 In-Reply-To: <2981cbf6-e953-3f07-70d8-eac3ac78145e@redhat.com> (Pedro Alves's message of "Wed, 8 Nov 2017 11:42:27 +0000") Message-ID: <87tvy4r3k4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eCViO-0019Ic-QA X-Source-Sender: 71-218-90-63.hlrn.qwest.net (bapiya) [71.218.90.63]:52892 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2017-11/txt/msg00189.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> So now I'm thinking that your patch must be correct. I'd still Pedro> like to learn more about where is it that we intern the symbol Pedro> names, though, and I still think it'd be great to add a comment Pedro> to the code. It happens via symbol_set_names. There is some subtlety here in that sometimes a name won't be copied (this saves memory by referring to strings in the mapped debuginfo), and also IIRC Ada adds some complexities too. I can add comments to the psymbol hash and comparison functions to mention this. Tom