From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74532 invoked by alias); 28 May 2018 22:06:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74521 invoked by uid 89); 28 May 2018 22:06:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Cc, restored, Hx-languages-length:1416, super X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 May 2018 22:06:05 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 71606D5D8 for ; Mon, 28 May 2018 17:06:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NQHCfbxaibXuJNQHCfscA5; Mon, 28 May 2018 17:06:02 -0500 X-Authority-Reason: nr=8 Received: from 174-29-44-154.hlrn.qwest.net ([174.29.44.154]:47818 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fNQHC-001K5t-3g; Mon, 28 May 2018 17:06:02 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 0/9] Radically simplify the complaint system References: <20180522050704.10845-1-tom@tromey.com> <190d88e2-35a5-9dc2-8b28-4a8c37e0617a@redhat.com> <87d0xmfodf.fsf@tromey.com> <8736yczdj3.fsf@tromey.com> Date: Mon, 28 May 2018 22:19:00 -0000 In-Reply-To: (Pedro Alves's message of "Mon, 28 May 2018 19:57:36 +0100") Message-ID: <87tvqrxwon.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fNQHC-001K5t-3g X-Source-Sender: 174-29-44-154.hlrn.qwest.net (bapiya) [174.29.44.154]:47818 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00747.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: [ QUIT ] Pedro> And then when that happens, 'complaints.c'::series is not Pedro> restored back [because the clear_complaints call is skipped, Pedro> because it is not exception safe], so all the following Pedro> complaints are issued with SHORT_FIRST_MESSAGE: Hah, oops. I have a series now to remove SHORT_FIRST_MESSAGE. It still won't be perfect here -- there's no cleanup object still and so you could in theory see too many complaints if you C-c at the wrong time. I don't think that is super important though. Pedro> I guess I just see complaint output similar to "set debug foo" output, Pedro> where I also wish we were more consistent in printing some leading Pedro> prefix for each debug knob, like, "set debug infrun 1" producing Pedro> output messages prefixed with "infrun:" or something like that. This makes sense to me too. I was tempted to just remove it entirely, but it is nice to be able to throttle the messages, since ordinarily there are many of the same kind in a given objfile. Pedro> Not sure what you mean here. I was just thinking of something like Pedro> simply making sure to include "DWARF reader:" in all complaint calls in Pedro> dwarf2read.c. Ok, I see. I thought you meant something where symfile would tell the complaints system about the module in question. Tom