From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3636 invoked by alias); 6 Jun 2018 22:38:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2405 invoked by uid 89); 6 Jun 2018 22:38:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:keiths@, sk:keiths, U*keiths, keiths@redhat.com X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Jun 2018 22:38:06 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway22.websitewelcome.com (Postfix) with ESMTP id E6B43B159 for ; Wed, 6 Jun 2018 17:38:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Qh42f2EbjbXuJQh45fHJpb; Wed, 06 Jun 2018 17:38:04 -0500 X-Authority-Reason: nr=8 Received: from 75-166-19-45.hlrn.qwest.net ([75.166.19.45]:43026 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fQh41-001Hr3-NR; Wed, 06 Jun 2018 17:37:58 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Change build_address_symbolic to return std::string References: <20180505162454.5619-1-tom@tromey.com> Date: Wed, 06 Jun 2018 22:38:00 -0000 In-Reply-To: (Keith Seitz's message of "Wed, 6 Jun 2018 11:38:47 -0700") Message-ID: <87tvqf35j0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fQh41-001Hr3-NR X-Source-Sender: 75-166-19-45.hlrn.qwest.net (bapiya) [75.166.19.45]:43026 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00163.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Did someone looks this over already? Nope. >> +extern int build_address_symbolic (struct gdbarch *, >> + CORE_ADDR addr, >> + int do_demangle, >> + std::string *name, >> + int *offset, >> + std::string *filename, >> + int *line, >> + int *unmapped); Keith> Since you're moving the declaration here, could you please copy Keith> the comment from the definition here, too, while you're at it, Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM] Good idea, I've made this change locally. Tom