From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15043 invoked by alias); 11 Aug 2018 15:01:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15014 invoked by uid 89); 11 Aug 2018 15:01:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.192.36) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Aug 2018 15:00:58 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 55359400F7569 for ; Sat, 11 Aug 2018 09:04:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oVNxftV91kBj6oVNxfAirT; Sat, 11 Aug 2018 10:00:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vMzMw/ugfWIAB8ST/R3+0+AjPZsN8QIbGI2XFGzZxbE=; b=Cplm9Cp73HJRgDer76PPdVCUOz bJp8Nkt57i7AddFXhQh+kHTMdB2nJKU32jP7XZ6uShQ899OfJpMa9q/9CLWb70zVryjUMHtUs4BUM dZFdrKqeu0rQvKwSMoUaMzIJE; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:57176 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1foVNx-003cRn-84; Sat, 11 Aug 2018 10:00:57 -0500 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-5-keiths@redhat.com> Date: Sat, 11 Aug 2018 15:01:00 -0000 In-Reply-To: <20180810232534.481-5-keiths@redhat.com> (Keith Seitz's message of "Fri, 10 Aug 2018 16:25:29 -0700") Message-ID: <87tvo1t0bb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00319.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> This patch converts linespec.c's linespec.label_symbols member from a Keith> VEC to a std::vector. Keith> gdb/ChangeLog: Keith> * linespec.c (struct linespec) : Change type to Keith> std::vector. Update all users. Keith> (struct collect_info) : Likewise. Keith> (find_method, find_function_symbols, find_linespec_symbols): Change Keith> `minsyms' parameter to std::vector. Update all callers. Thank you. Keith> + qsort (ls->minimal_symbols->data (), ls->minimal_symbols->size (), Keith> + sizeof (bound_minimal_symbol), compare_msymbols); I think this should be changed to use std::sort. If I'm reading correctly, this is the only caller of compare_msymbols, so this transform shouldn't be too hard to do. Tom