From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120034 invoked by alias); 31 Aug 2018 15:38:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120025 invoked by uid 89); 31 Aug 2018 15:38:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:38:42 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28C5D807689D; Fri, 31 Aug 2018 15:38:41 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08A4310D14D0; Fri, 31 Aug 2018 15:38:40 +0000 (UTC) From: Sergio Durigan Junior To: Gary Benson Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH v2] Indicate batch mode failures by exiting with nonzero status References: <1534934813-10188-1-git-send-email-gbenson@redhat.com> <8736uviosv.fsf@redhat.com> Date: Fri, 31 Aug 2018 15:38:00 -0000 In-Reply-To: (Gary Benson's message of "Fri, 31 Aug 2018 14:30:23 +0100") Message-ID: <87tvnah7gi.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00870.txt.bz2 On Friday, August 31 2018, Gary Benson wrote: > On 30 August 2018 at 21:26, Sergio Durigan Junior wrote: >> On Wednesday, August 22 2018, Gary Benson wrote: >>> This patch causes GDB in batch mode to exit with nonzero status >>> if the last command to be executed fails. >>> >>> Changes since version 1: >>> - I've reworked the patch to not use a global variable. >>> - Behaviour has not changed from version 1. >>> >>> Built and regtested on RHEL 7.5 x86_64. >> >> Hey, just to make sure this is reported here: I'm seeing failures when >> running this test on my Fedora 28 x86_64: >> >> FAIL: gdb.base/batch-exit-status.exp: -batch -jslkflsdjlkfjlksdjf: $actual_status == $expect_status >> FAIL: gdb.base/batch-exit-status.exp: -batch -ex "set not-a-thing 4": $actual_status == $expect_status >> FAIL: gdb.base/batch-exit-status.exp: -batch -x >> /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.bad-commands: >> $actua$ >> _status == $expect_status >> FAIL: gdb.base/batch-exit-status.exp: -batch -x >> /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.good-commands >> -x /ho$ >> e/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.bad-commands: $actual_status == $expect_status >> FAIL: gdb.base/batch-exit-status.exp: -batch -x >> /home/sergio/work/src/git/binutils-gdb/build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/batch-exit-status.good-commands >> -ex "s$ >> t not-a-thing 4": $actual_status == $expect_status >> >> This has also been caught by the BuildBot: >> >> https://sourceware.org/ml/gdb-testers/2018-q3/msg05129.html >> https://sourceware.org/ml/gdb-testers/2018-q3/msg05223.html >> >> Let me know if you need more details. > > Yes please! Is it failing on *every* platform? I looked in gdb.log.xz > but there's no output from GDB, only the PASS/FAIL lines. So I don't > really know what to do, I can't reproduce :/ Hey Gary, At least according to the BuildBot, the test is failing on Fedora x86_64 (F-28). I don't see the failures on s390x, but maybe that's because they're running old systems... I guess you might be able to reproduce this if you run the test on a Fedora 28 machine/VM. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/