From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39932 invoked by alias); 23 Sep 2018 21:12:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39911 invoked by uid 89); 23 Sep 2018 21:12:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=backwards, locally, yep X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 21:12:20 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id A950223B7AE for ; Sun, 23 Sep 2018 16:12:18 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4BfugAAGZaSey4BfugZQxg; Sun, 23 Sep 2018 16:12:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpegcEOgONCn/+WWoFGNG0Wv+CN7hK79+5V+9it8J40=; b=jVQRpNJa/GRcdt36QSRKjmY6Bb gvZjQ+5R6l46XUsJTdSjnRj6uspqinXdjKeNfrl9Qce2AnEgrq1FPcsW88sQTQMmBgg0CFlbQKALe 4zu8IwaM5I5Clrh5C7yaVLQ64; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:41338 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g4Bfu-001RJK-DK; Sun, 23 Sep 2018 16:12:18 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 05/15] Simplify calls to init_psymbol_list References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-6-tom@tromey.com> Date: Sun, 23 Sep 2018 21:12:00 -0000 In-Reply-To: (Simon Marchi's message of "Tue, 17 Jul 2018 22:50:59 -0400") Message-ID: <87tvmflxzi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00781.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> void >> init_psymbol_list (struct objfile *objfile, int total_symbols) >> { >> - /* Free any previously allocated psymbol lists. */ >> - objfile->global_psymbols.clear (); >> - objfile->static_psymbols.clear (); >> + if (objfile->global_psymbols.capacity () == 0 >> + && objfile->static_psymbols.capacity () == 0) >> + return; Simon> Hmm, isn't the condition backwards? Yep. Simon> Would LGTM with the condition fixed (assuming I am not the one being confused) Simon> or removed. I've fixed it locally. Tom