From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix 4K leak in open_source_file each time next/step changes of function.
Date: Mon, 05 Nov 2018 20:02:00 -0000 [thread overview]
Message-ID: <87tvkvmgwj.fsf@tromey.com> (raw)
In-Reply-To: <20181104165507.24341-1-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sun, 4 Nov 2018 17:55:07 +0100")
>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
Philippe> Note that I do not understand why find_and_open_source always tries to
Philippe> re-execute the substitution rules on the provided fullname, as source.c
Philippe> symtab_to_fullname just blindly returns a non NULL s->fullname, counting on
Philippe> forget_cached_source_info to be called if search dir or substitution rules are
Philippe> changed. Similarly, psymtab_to_fullname also just returns a non NULL
Philippe> ps-> fullname.
It would be good to investigate & maybe remove this.
Philippe> 2018-11-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
Philippe> * source.c (open_source_file): Fix leak by transferring the
Philippe> current s->fullname to the unique_xmalloc_ptr fullname given
Philippe> to find_and_open_source.
Thanks, this is ok.
Tom
next prev parent reply other threads:[~2018-11-05 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 16:55 Philippe Waroquiers
2018-11-05 20:02 ` Tom Tromey [this message]
2018-11-05 20:46 ` Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvkvmgwj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox