From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110373 invoked by alias); 29 Nov 2018 19:18:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110359 invoked by uid 89); 29 Nov 2018 19:18:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Pan, Hx-languages-length:634, Problem X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Nov 2018 19:18:28 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 137112611C for ; Thu, 29 Nov 2018 13:18:27 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id SRpTg2AvM957pSRpTglBi6; Thu, 29 Nov 2018 13:18:27 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EHBinptEkG7JWUfjWQkIE+3ONAPCaZGqtoRufoQRg40=; b=aebBtPiPU8St7sdlB5gyo8g1We dZENN2w4XVOBrGq8I+UTVN/WIo08ZFGA8kdIf3UxohQhNHlk8iucUTgU9sMqLuZ7yaXdQ20ceMGA8 UV8Fmz9EjQT6pAtiMYQ0LMtHE; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:33200 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSRpS-001KBZ-QJ; Thu, 29 Nov 2018 13:18:26 -0600 From: Tom Tromey To: Wei-min Pan Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH PR gdb/20057] Internal error on trying to set {char[]}$pc="string" References: <1516844738-79996-1-git-send-email-weimin.pan@oracle.com> <20180125041431.tghhxefsgxnxh3l3@adacore.com> <1dfc87b0-353d-3388-a427-fee247dc79a5@oracle.com> <20180131074526.rqbsjxyxp3p26js5@adacore.com> <1d28e9c6-6377-0c46-6bce-1dc25a7fa2d5@oracle.com> <20180201075955.mnqxzmw4ktuy3f5d@adacore.com> <20181114235153.GB4336@adacore.com> Date: Thu, 29 Nov 2018 19:18:00 -0000 In-Reply-To: (Wei-min Pan's message of "Wed, 14 Nov 2018 16:15:37 -0800") Message-ID: <87tvjzae0u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00548.txt.bz2 >>>>> ">" == Wei-min Pan writes: >> Problem is copy_type will assert on to-be-copied type which does not >> have an >> associated objfile. It doesn't matter if the type is entirely arch-owned. I didn't follow this thread in too much detail, but FWIW I believe the rule is that an objfile-owned type can refer to a gdbarch-owned type -- but not vice versa. Following that it seems to me that there should not be a need to call copy_type on a gdbarch-owned type. So maybe that can be avoided, instead of removing the assert? Tom