From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74627 invoked by alias); 30 Nov 2018 19:49:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74534 invoked by uid 89); 30 Nov 2018 19:49:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Nov 2018 19:49:31 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 9F13026102 for ; Fri, 30 Nov 2018 13:49:30 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Son4grphjkBj6Son4gnhIq; Fri, 30 Nov 2018 13:49:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=3cqyY2LzjzITFaRfSQVDQ7TLsc9Mr6RcOh+FDGWOgAc=; b=Bl3QD6+nkbsMjk/aNqey15e29g m1KzktqxmF1BPRItfjkDtA2r8tCZDoMnnc+oRzOvTALINUUDtgQJa5I4GDZJW9O1IVBbzwPnUlx+h XfanNqXuuu8LVJfPjmgfZrF9o; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:58412 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gSon4-0023Un-DE; Fri, 30 Nov 2018 13:49:30 -0600 From: Tom Tromey To: Tom de Vries Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase References: <20181004174015.GA20307@delia> <20181009134747.GA1742@delia> Date: Fri, 30 Nov 2018 19:49:00 -0000 In-Reply-To: <20181009134747.GA1742@delia> (Tom de Vries's message of "Tue, 9 Oct 2018 15:47:47 +0200") Message-ID: <87tvjymjli.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-11/txt/msg00582.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> 2018-10-09 Tom de Vries Tom> * gdb.base/gdb-caching-proc.exp: New file. Thanks for the patch. I didn't see a review or see this go in, so hopefully this isn't redundant. Tom> +# Test gdb_caching_proc NAME Tom> +proc test_proc { name } { Tom> + set real_name gdb_real__$name Tom> + Tom> + set first [$real_name] Tom> + lappend resultlist $first I think this lappend is unnecessary... Tom> + set resultlist [list] ... because resultlist is reset here. But maybe you intended to hoist this earlier? Either way is fine by me. This is ok with this nit addressed. Tom