From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58493 invoked by alias); 15 Dec 2018 22:48:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58276 invoked by uid 89); 15 Dec 2018 22:48:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=referred X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 15 Dec 2018 22:48:24 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 8CE482DAE80 for ; Sat, 15 Dec 2018 16:48:03 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YIj5gQMPriQerYIj5gWa0O; Sat, 15 Dec 2018 16:48:03 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FMhVw7WFrPaNduqi99BQ80Od1r9W6SyhOhr8EmohIc8=; b=vDye8R4RcpsixQBZTRs5GLMnMk IAY18KrgozheaNgYmI8Scl7dt6UtSv1Hxl75krZQ99F4+S+3SF5skN+I9GEKfNZBojRZqEMRL7nNi Uj3H0ODaYFynkk+g4BEEygWzp; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:45340 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gYIj5-000ff6-Ag; Sat, 15 Dec 2018 16:48:03 -0600 From: Tom Tromey To: Svante Signell Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Please define thread_info as struct thread_info (and other stuff) References: Date: Sat, 15 Dec 2018 22:48:00 -0000 In-Reply-To: (Svante Signell's message of "Sat, 15 Dec 2018 20:36:33 +0100") Message-ID: <87tvje5rvh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00172.txt.bz2 >>>>> "Svante" == Svante Signell writes: Svante> When building gdb version 8.2 on GNU/Hurd several problems arise that need to be Svante> solved. One problem is that most files in gdb/ have sloppy definitions of struct Svante> thread_info, causing a build stop fore every occurrence. They are excluding the Svante> struct part, making the build (and port) on Hurd very cumbersome. Can you please Svante> fix all bad references to thread_info upstream? I don't really understand how Svante> gcc can let these errors pass on GNU/Linux. In C++ there's an implicit typedef for a struct tag, so "struct thread_info" can also just be referred to as "thread_info". So, I tend to think the code is fine and something else is going wrong. You didn't post the text of the error or the version of the compiler that you are using, so it's hard to say more about what the problem is. Could you send that info? Svante> More patches will be needed for a successful port of gdb-8.2 to GNU/hurd, but Svante> please fix the above problems upstream first. I didn't go through all the patches, but I suggest sending a series rather than one large message; following the contribution checklist; and finally, working off git master rather than a branch. thanks, Tom