From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28377 invoked by alias); 26 Jan 2019 03:58:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28367 invoked by uid 89); 26 Jan 2019 03:58:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*ca X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.101) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Jan 2019 03:58:19 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway32.websitewelcome.com (Postfix) with ESMTP id BA15289A207 for ; Fri, 25 Jan 2019 21:58:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id nF6ng27D0YTGMnF6ngk7AU; Fri, 25 Jan 2019 21:58:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JWb/W/HWBpHKS0dbhxRNr6vnm9j2D8s95xgFAZIt+Qg=; b=KEixLdiYmYrogb6Bmg3Ev6EQOw dImI0suNmz8nXchVtF8kDcvZhIOU0W+0T6aqCFDvowxBKhEE/VDp8RP93SyIRMaCmV63CQaH8PB52 1AjoPvMSG7q5zonE0XRa8EoSB; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:58084 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gnF6n-002OVW-FH; Fri, 25 Jan 2019 21:58:17 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Update create-version.sh to use common/version.h References: <20190123172954.24421-1-tom@tromey.com> <20190123172954.24421-2-tom@tromey.com> <6adb597a88e229b7996d156ea8208438@polymtl.ca> Date: Sat, 26 Jan 2019 03:58:00 -0000 In-Reply-To: <6adb597a88e229b7996d156ea8208438@polymtl.ca> (Simon Marchi's message of "Fri, 25 Jan 2019 22:32:59 -0500") Message-ID: <87tvhwm5nr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00555.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> An easy way to fix this would be to add -I$(srcsim) to the include Simon> paths in sim/common/Make-common.in. We could actually think of giving Simon> the same treatment of removing -I../common and -I$(srccom) to sim than Simon> what you did to GDB. I don't really know much about the sim, so I don't really have an opinion on whether that makes sense there. For the immediate problem, I think it's usually not good to have these hidden cross-directory dependencies. This one seems particularly bad because it's somewhat uncommon to even build the sim. How about just copying create-version.sh to sim/common and having it use the old #include "version.h"? Then the two scripts can evolve in their own ways as needed, without worrying. Tom