From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25345 invoked by alias); 6 Mar 2019 21:12:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25337 invoked by uid 89); 6 Mar 2019 21:12:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 21:12:45 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 65F839A958 for ; Wed, 6 Mar 2019 15:12:44 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1dqGhu5nNdnCe1dqGhp1e5; Wed, 06 Mar 2019 15:12:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cU6OMhTy2D0JGiDRquoj+vFjeEUfM38Jm2pgQRSH3aE=; b=vF71yr/YF/ERwBo0VYYuBt8a+x /z4/IaSMwG9vpqrhgpYf/aK3+3DRR4HGY1PYtDwTcjj9+wtpWsUZlMe6iJMOLQyIO3frEiNAbujNg R87IkupzFHtkRRuPxH2j9blHY; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:60178 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1dqF-001VFN-Ud; Wed, 06 Mar 2019 15:12:44 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 04/22] C++ify remote notification code References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-5-tom@tromey.com> <6f911dfb-3018-33b0-fbb1-48ece1607c1e@redhat.com> Date: Wed, 06 Mar 2019 21:12:00 -0000 In-Reply-To: <6f911dfb-3018-33b0-fbb1-48ece1607c1e@redhat.com> (Pedro Alves's message of "Wed, 6 Mar 2019 19:23:26 +0000") Message-ID: <87tvgflnat.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00124.txt.bz2 >> + std::unique_ptr event = nc->alloc_event (); Pedro> "std::unique_ptr" appears in a number of places Pedro> in the patch. Did you consider adding a "notif_event_up" typedef ? Nope, but I've added it now. >> -typedef std::unique_ptr stop_reply_up; >> +typedef std::unique_ptr stop_reply_up; Pedro> Odd that you added the "struct". I tend to remove it when touching Pedro> code instead. :-) I changed this back. Tom