From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52661 invoked by alias); 14 Mar 2019 12:21:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52651 invoked by uid 89); 14 Mar 2019 12:21:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:316 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.55.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Mar 2019 12:21:01 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4D66F400D5CF9 for ; Thu, 14 Mar 2019 07:21:00 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4PM3hXxdNiQer4PM3hN1pU; Thu, 14 Mar 2019 07:21:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WkCN5yw0yjPV5giPh9vf5+LXb6abZG7J3VaqFUvotG0=; b=MU+rIzIBt8QIFKOtSTH+Sl480C Pg2tv8b9nUSREfYMsntJPdymz3evz8ZR8/LrJTQ/BBhetHVV0t81+ZTxHU4eKGpylMABJl9aGrFsm UAt8QaUNluOqs6m8H6IVA32On; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:43664 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h4PM3-001eRT-2a; Thu, 14 Mar 2019 07:20:59 -0500 From: Tom Tromey To: Eli Zaretskii Cc: tromey@adacore.com, gdb-patches@sourceware.org Subject: Re: [RFC 8.3 0/3] Some style fixes References: <20190308210433.32683-1-tromey@adacore.com> <83pnr08tc8.fsf@gnu.org> <83zhq26fcw.fsf@gnu.org> <874l899nh3.fsf@tromey.com> <8336ns3uv4.fsf@gnu.org> <83k1h23hat.fsf@gnu.org> Date: Thu, 14 Mar 2019 12:21:00 -0000 In-Reply-To: <83k1h23hat.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 13 Mar 2019 17:50:02 +0200") Message-ID: <87tvg5fxzp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00290.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> +#ifdef __MINGW32__ Eli> +#include Eli> +static SHORT ncurses_norm_attr; Eli> +#endif I'd somewhat prefer it if the definition were in a separate block after all the includes. The rest seems fine to me. Tom