From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50229 invoked by alias); 2 Aug 2019 13:43:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50217 invoked by uid 89); 2 Aug 2019 13:43:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SEMBLACK,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:914, H*Ad:U*tom X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.196.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Aug 2019 13:43:13 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A771F9116 for ; Fri, 2 Aug 2019 08:43:12 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tXpwheHRa3Qi0tXpwhONHf; Fri, 02 Aug 2019 08:43:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oY0cst1rkOWKssbSL1BvRkhEjEfgM2olJ2L2/USfQxc=; b=fZoIfT8QltnlSF2yD1DK1rvmTQ CA5ODP9eshITUYtk4zKYM57XwzYHZ1L8mLtBx4eXQwFplBezvDXQ6Tj40FIsCn8d/TZB8VNRnkYCd AffmB6eTbF5b21GsNj4XWgAVb; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:35024 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1htXpw-001byk-Dk; Fri, 02 Aug 2019 08:43:12 -0500 From: Tom Tromey To: Tom de Vries Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp References: <20190801143855.1640-1-simon.marchi@efficios.com> <87ftmkagwi.fsf@tromey.com> <9cc09b45-ba14-3299-6f99-b738c349ed94@efficios.com> Date: Fri, 02 Aug 2019 13:43:00 -0000 In-Reply-To: (Tom de Vries's message of "Fri, 2 Aug 2019 08:39:14 +0200") Message-ID: <87tvazisy8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00044.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> for me, both tests fail with a timeout. And if we're increasing the Tom> timeout, how about we only do that if check-read1 is used? I'm reluctant to make the test suite more sensitive to the environment it's running it. Is the reason to do this that the test can time out normally, and so we'd like to avoid lengthy timeouts? If that's the case, can the test be fixed somehow instead? I guess my mental model here is that a timeout should not matter unless a test is flaky. But maybe that's naive? I don't know :-) Tom> +proc with_timeout_factor { factor body {body_uplevel 1}} { I think body_uplevel shouldn't be needed. Tom> + return [with_timeout_factor $factor $body 2] ... since this can just do return [uplevel [list with_timeout_factor $factor $body]] thanks, Tom