From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31177 invoked by alias); 19 Sep 2019 18:28:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31169 invoked by uid 89); 19 Sep 2019 18:28:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:759 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2019 18:28:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7A95E1178A6; Thu, 19 Sep 2019 14:27:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sKY8WSwLnV3m; Thu, 19 Sep 2019 14:27:59 -0400 (EDT) Received: from murgatroyd (71-218-73-27.hlrn.qwest.net [71.218.73.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id E4E9D117831; Thu, 19 Sep 2019 14:27:58 -0400 (EDT) From: Tom Tromey To: Tom Tromey Cc: Andrew Burgess , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/8] Handle copy relocations References: <20190801170412.5553-1-tromey@adacore.com> <20190801170412.5553-3-tromey@adacore.com> <20190821153528.GH6076@embecosm.com> <87ftlul4ed.fsf@tromey.com> <20190822084129.GK6076@embecosm.com> <87zhj0qiy1.fsf@tromey.com> Date: Thu, 19 Sep 2019 18:28:00 -0000 In-Reply-To: <87zhj0qiy1.fsf@tromey.com> (Tom Tromey's message of "Thu, 19 Sep 2019 11:44:54 -0600") Message-ID: <87tv98qgy9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00374.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Andrew> I guess I'm thinking that we could merge the core of Andrew> lookup_minimal_symbol_text and lookup_minimal_symbol_linkage (or Andrew> _data), and just pass in a comparison function to check for either Andrew> text or data symbols. Tom> Sounds good, I'll try that. There is already a separate debug iterator, Tom> so maybe that can be used as well. I looked at this, but there isn't really that much to share. IMO callbacks tend to obfuscate the code. So I think I'd rather not do that, if that's ok with you. Maybe introducing an iterator over minimal symbols, given a hash, would simplify things a bit. But, that's not really much of a savings. Tom