From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39092 invoked by alias); 26 Sep 2019 17:50:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39080 invoked by uid 89); 26 Sep 2019 17:50:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 17:50:40 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8299793C9; Thu, 26 Sep 2019 17:50:38 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id F30CA600C6; Thu, 26 Sep 2019 17:50:36 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches , Pedro Alves , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH v5] Improve ptrace-error detection on Linux targets References: <20190819032918.3536-1-sergiodj@redhat.com> <20190926042155.31481-1-sergiodj@redhat.com> <87d0fngdyx.fsf@tromey.com> Date: Thu, 26 Sep 2019 17:50:00 -0000 In-Reply-To: <87d0fngdyx.fsf@tromey.com> (Tom Tromey's message of "Thu, 26 Sep 2019 11:32:54 -0600") Message-ID: <87tv8zhrpv.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00536.txt.bz2 On Thursday, September 26 2019, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> Changes from v4: > Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use > Sergio> conventional try..catch. > > Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't > Sergio> overflow the buffer. > > Thank you for doing this. > I think this is ok, please check it in. Thanks for the extensive reviews, Tom and Pedro. Pushed: 381beca6146ac68b57edf47d28cdb335fbd11635 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/