From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45724 invoked by alias); 13 Jan 2020 17:33:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45670 invoked by uid 89); 13 Jan 2020 17:33:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:539 X-HELO: gateway21.websitewelcome.com Received: from gator3069.hostgator.com (HELO gateway21.websitewelcome.com) (192.185.45.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 17:33:54 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 0C8BA401D3B88 for ; Mon, 13 Jan 2020 11:33:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id r3b6iJ38RHiO0r3b6iHECm; Mon, 13 Jan 2020 11:33:53 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xxUgpcFkgwCTcozPCZ37141/oY3KY7e5YAn5F8Ao394=; b=F88Wd5AG+YiEPBnCYg6sN3SCsp oMhB2fxIPGzT5lJzSEQXn1Q1yoL5YszHYYME9scFoDLyhH7sXlx6lfmZiKqZ2g2FlY0c5wUuhLIny faHjrLQKtx9vwr2WIN4nmTx1N; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:41014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ir3b6-000Y1y-Aq; Mon, 13 Jan 2020 10:33:52 -0700 From: Tom Tromey To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org, Tom Tromey , Joel Brobecker Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic References: <20200110220027.26450-1-simon.marchi@efficios.com> Date: Mon, 13 Jan 2020 17:42:00 -0000 In-Reply-To: (Simon Marchi's message of "Sun, 12 Jan 2020 15:22:18 -0500") Message-ID: <87tv4zp8g0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00338.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> As I tried building gdbserver with a few cross compilers, I found another Simon> build issue, with code generated by regdat.sh. The following patch addresses Simon> it. It should not be too controversial, but I wanted to run it by you first. Simon> gdb/ChangeLog: Simon> * regformats/regdat.sh: Generate declaration for init function. This is fine by me. I agree with your analysis in the commit message. Tom