From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127170 invoked by alias); 12 Feb 2020 00:29:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127088 invoked by uid 89); 12 Feb 2020 00:29:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.198.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 00:29:00 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id C8B96693A for ; Tue, 11 Feb 2020 18:28:58 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1ftijI4HRSl8q1ftij17zi; Tue, 11 Feb 2020 18:28:58 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UJdx73Ii0yCv31YEPAHp3B6LV/IBDTyU2ExcJAtPwrE=; b=CYvOMdaPJgmKCPkcO+pouFdtz5 iQNW+sMI0B34q2VG4FAwoFvXzmEYdDEU37cEVxioA9JvuIuxqObTGglBEIbNpwx7Xjs/967RQRJGU IjKWNa85gNGfymqKlE/RRaz2E; Received: from 50-194-130-62-static.hfc.comcastbusiness.net ([50.194.130.62]:36058 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j1fti-001K7f-II; Tue, 11 Feb 2020 17:28:58 -0700 From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/8] Change fde table to a vector References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-4-tom@tromey.com> <5a373a74-9283-5d82-a22d-7a2606a4d3f5@linaro.org> Date: Wed, 12 Feb 2020 00:29:00 -0000 In-Reply-To: <5a373a74-9283-5d82-a22d-7a2606a4d3f5@linaro.org> (Luis Machado's message of "Tue, 11 Feb 2020 07:26:56 -0300") Message-ID: <87tv3wbqd2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00421.txt.bz2 >>>>> "Luis" == Luis Machado writes: Luis> We don't quite allocate space for it anymore, but we do behind the Luis> scenes. The comment seems slightly stale. Plus the sentence reads a Luis> bit funny. I'd update this, but i'm fine keeping it too. I simplified it to just: /* Add FDE to FDE_TABLE. */ >> /* Copy fde_table to obstack: it is needed at runtime. */ >> - fde_table2 = XOBNEW (&objfile->objfile_obstack, struct dwarf2_fde_table); >> + fde_table2 = new dwarf2_fde_table; > Luis> The comment mentioning obstack is now obsolete and can be removed. I've removed it. I think this is the one you mentioned in another patch review -- but it is simple enough to just zap it here and fix up the conflict. Tom