From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79168 invoked by alias); 14 Feb 2020 02:22:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79158 invoked by uid 89); 14 Feb 2020 02:22:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.125) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 14 Feb 2020 02:22:05 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 8B4EAC9E01 for ; Thu, 13 Feb 2020 20:22:01 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2QcBj3eVgEfyq2QcBjD0zE; Thu, 13 Feb 2020 20:22:01 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=U8Cb6L8cXzIonsm/wdcicpD6Y5xnAhfAAJCIEqSoqY8=; b=jmPsx41NpIGNclOzWHU/s3N+E7 45DNCLcFhhr+WG8NgmRjqP6NekDTzdm33RuFKQSpnSYWlZFCaPxtcTfjh2NsoC3bofdfOTqGgD7rk xb4+aMQxtzPtGpJ8Bsq5Mt5qu; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:60242 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j2QcB-0001Zf-JO; Thu, 13 Feb 2020 19:21:59 -0700 From: Tom Tromey To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFC 00/17] Merge event loop implementations References: <20190224165153.5062-1-tom@tromey.com> <3ae5ab8e-c219-6510-bb54-b30c1cf2d074@redhat.com> <87mueqslhn.fsf@tromey.com> <52b71425-e839-99fa-5045-8aaa02eafaef@redhat.com> <87a7apeesm.fsf@tromey.com> Date: Fri, 14 Feb 2020 02:22:00 -0000 In-Reply-To: <87a7apeesm.fsf@tromey.com> (Tom Tromey's message of "Fri, 27 Sep 2019 13:10:17 -0600") Message-ID: <87tv3taoxl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00549.txt.bz2 Tom> However, my hope was that unifying on the gdb approach would be good Tom> enough. And, while debugging on Windows this week, I happened (I forgot Tom> to look before starting, so it's kind of a goofy accident) to use this Tom> event unification branch. I used gdb and also tried gdbserver, and as Tom> far as I can tell, everything worked fine. I rebased this series recently. I wasn't sure what the status really was. I thought this at the time: Tom> So, my view is that the current patch series is probably roughly ok. ... meaning that gdb_fildes_t could be removed and replaced with plain "int", and nothing else would have to change. I can re-test the series on Windows. The updates due to rebasing were all mechanical, though, stuff like making sure the files were moved into the now-correct directories. I thought maybe we could use gdb_select in gdbsupport, but now I see it reaches into the serial code, so maybe that isn't so easy after all. Let me know what you think. Tom