From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.151.58]) by sourceware.org (Postfix) with ESMTPS id 1DD143951C6F for ; Tue, 19 May 2020 16:04:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DD143951C6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id B5686233A19 for ; Tue, 19 May 2020 11:04:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b4jAjGIvGEfyqb4jAj0Wn1; Tue, 19 May 2020 11:04:24 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TXSLT3b+j4XvOm+A37sKrXerdTBC1AYkYtidCgIuAW4=; b=wG6GuNs21/1qmvxMXM0Bj4ah6P /cSgqD4rvyfmlHgm7wD1vxTOzqqxph2oEAOf+XRVLe1jLvBmj9j77RlMcazAsVHIZeOuqiUyfDynN rMGULbvsAq2AePxCX3YhWDqor; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:52960 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jb4jA-002Tp1-F9; Tue, 19 May 2020 10:04:24 -0600 From: Tom Tromey To: Pedro Alves via Gdb-patches Cc: Pedro Alves Subject: Re: [PATCH v2 3/3] Make exec-file-mismatch compare build IDs References: <20200517180450.14925-1-palves@redhat.com> <20200517180450.14925-4-palves@redhat.com> X-Attribution: Tom Date: Tue, 19 May 2020 10:04:23 -0600 In-Reply-To: (Pedro Alves via Gdb-patches's message of "Mon, 18 May 2020 14:55:28 +0100") Message-ID: <87tv0b7vy0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jb4jA-002Tp1-F9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:52960 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 16:04:26 -0000 >>>>> "Pedro" == Pedro Alves via Gdb-patches writes: Pedro> On 5/17/20 7:04 PM, Pedro Alves via Gdb-patches wrote: >> The patch makes GDB first try exec-file-mismatch validation via build >> IDs, and then if that isn't possible, fallback to validating using the >> old method of comparing filenames. I'd argue that we should remove >> the filename validation for causing too many false positives, though. Agreed. Pedro> Here's an updated version that removes the filename comparison. Pedro> I've kept the structure of the code the same, in case we Pedro> add some form of fallback later on. It makes sense to me. I read these patches and they look good to me. Tom