From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.184.18]) by sourceware.org (Postfix) with ESMTPS id C8B67386F471 for ; Fri, 22 May 2020 20:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C8B67386F471 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 3EB42400D001C for ; Fri, 22 May 2020 14:31:48 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cE1aju7hHAGTXcE1aj8JYm; Fri, 22 May 2020 15:12:10 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kjlUL1k1yS62cOOoxG0knxxmgf85EqYP+1CF6CRFCzQ=; b=Qtno5clHSQ5bN7up9/VF6n6P1W sHbNbyoOpG4//il9nPOMm1uSzJlaCtwR6fpS1DN3YStHIr1Nz3cjIMvjpNyoZz/WQaHIFj2zSKGRX PVetJZK4raesEOPXC39DAczGU; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:35998 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcE1a-003l2R-1k; Fri, 22 May 2020 14:12:10 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3][gdb/testsuite] Fix global array cp_class_table_history leak References: <20200519162919.GA8981@delia> X-Attribution: Tom Date: Fri, 22 May 2020 14:12:09 -0600 In-Reply-To: <20200519162919.GA8981@delia> (Tom de Vries's message of "Tue, 19 May 2020 18:29:20 +0200") Message-ID: <87tv073f1i.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcE1a-003l2R-1k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:35998 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 20:12:12 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> +# This test-case uses the cp_test_ptype_class cache (by means of the ibid Tom> +# argument), so initialize and finalize the cache. Tom> +init_cp_test_ptype_class_cache Tom> + Tom> do_tests Tom> + Tom> +finish_cp_test_ptype_class_cache If the users always have to do this init/test/finish thing, then maybe some kind of wrapper proc would be more appropriate. Also, it's more robust to use 'catch' to ensure that the cleanup is always run. However, is the finish bit needed? If the init proc cleans up all the state, then it seems unnecessary. Tom