From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +AYAAfF4rV8EUwAAWB0awg (envelope-from ) for ; Thu, 12 Nov 2020 13:03:29 -0500 Received: by simark.ca (Postfix, from userid 112) id 01CFE1F08B; Thu, 12 Nov 2020 13:03:28 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B5411E58E for ; Thu, 12 Nov 2020 13:03:28 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F8C1385701E; Thu, 12 Nov 2020 18:03:28 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.24]) by sourceware.org (Postfix) with ESMTPS id 98B77385701E for ; Thu, 12 Nov 2020 18:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98B77385701E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 1A68945847B for ; Thu, 12 Nov 2020 12:03:25 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id dGwPkKDUOosA0dGwPkwRku; Thu, 12 Nov 2020 12:03:25 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N8qCnekEkk70hGqg/inJJkD9gOMJLKi7t9dZEazrwSk=; b=v7imXxRL+w+8FxUXlbRgxetRR0 sRJEMf1JSmWOmtfr0QL6HK+KjTnyi3c8rpFCawZOw1zUI5Mk0fetzkXgoZXmkUe5tS0/MUSAXKS/l tFz2w2WtQbkIpnlWGqVSw5rZL; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:36410 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kdGwO-000HFg-Mn; Thu, 12 Nov 2020 11:03:24 -0700 From: Tom Tromey To: Shahab Vahedi via Gdb-patches Subject: Re: [PATCH 2/2] gdb: Add native support for ARC in GNU/Linux References: <20201112134811.9074-1-shahab.vahedi@gmail.com> <20201112134811.9074-3-shahab.vahedi@gmail.com> X-Attribution: Tom Date: Thu, 12 Nov 2020 11:03:24 -0700 In-Reply-To: <20201112134811.9074-3-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Thu, 12 Nov 2020 14:48:11 +0100") Message-ID: <87tutucv0z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kdGwO-000HFg-Mn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:36410 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shahab Vahedi , Shahab Vahedi , Anton Kolesov , Francois Bedard Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Shahab" == Shahab Vahedi via Gdb-patches writes: Shahab> From: Anton Kolesov Shahab> With this patch in place it is possible to build a GDB that Shahab> can run on ARC (GNU/Linux) hosts for debugging ARC targets. Shahab> The "arc-linux-nat.c" is a rather small one that mostly deals Shahab> with registers and a few thread related hooks. Thanks for the patch. I read through it and have one nit. Shahab> +/* Suppress warning from -Wmissing-prototypes. */ Shahab> +void _initialize_arc_linux_nat (void); Shahab> + Shahab> +void Shahab> +_initialize_arc_linux_nat (void) You can remove the "void"s here, those are relics from the C days. This is ok with that tweak. Tom