From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Q8wGBaeVJGACGwAAWB0awg (envelope-from ) for ; Wed, 10 Feb 2021 21:25:43 -0500 Received: by simark.ca (Postfix, from userid 112) id 063581EF4F; Wed, 10 Feb 2021 21:25:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 72C0B1E789 for ; Wed, 10 Feb 2021 21:25:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A501E3857C50; Thu, 11 Feb 2021 02:25:41 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.127.2]) by sourceware.org (Postfix) with ESMTPS id 5C63A3857C50 for ; Thu, 11 Feb 2021 02:25:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5C63A3857C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id A65FB40138A80 for ; Wed, 10 Feb 2021 20:25:38 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id A1fmlWIWnSrGMA1fml6mXp; Wed, 10 Feb 2021 20:25:38 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=exasLmMGJAfF9hX1EqX/tBnBnWeuJWodB4DZU1nuyMc=; b=fc7L8QIKi4Pilbt/gQdHKvb3TK 0OIeV2uifjl87zkvhEV+QeJG4XIeEY4IGxNAb49QPC2uH5aOQObMKgWnnnIZJR2XzYGwWMXf0YSTV Pr98WbOZ+0HeJmZtwsZTswy9y; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:47970 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lA1fm-0030J3-9h; Wed, 10 Feb 2021 19:25:38 -0700 From: Tom Tromey To: Simon Marchi Subject: Re: [PATCH 009/203] what is this code for References: <20210101214723.1784144-1-tom@tromey.com> <20210101214723.1784144-10-tom@tromey.com> <20210103060009.GB285722@adacore.com> <3ecfae34-c2d5-873e-b67d-175beca08547@polymtl.ca> X-Attribution: Tom Date: Wed, 10 Feb 2021 19:25:37 -0700 In-Reply-To: <3ecfae34-c2d5-873e-b67d-175beca08547@polymtl.ca> (Simon Marchi's message of "Sun, 24 Jan 2021 21:28:48 -0500") Message-ID: <87tuqjuyqm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1lA1fm-0030J3-9h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:47970 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org, Joel Brobecker Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi writes: Simon> In addition to this good explanation: I tried removing the `|| pc == 0` Simon> from the code (based on current master) and got these failures: Simon> +FAIL: gdb.base/nodebug.exp: p sizeof(dataglobal + 1) Simon> +FAIL: gdb.base/nodebug.exp: ptype *dataglobal Simon> +FAIL: gdb.base/nodebug.exp: ptype dataglobal + 1 Simon> +FAIL: gdb.base/nodebug.exp: ptype sizeof(dataglobal + 1) Simon> +FAIL: gdb.base/nodebug.exp: whatis *dataglobal Simon> +FAIL: gdb.base/nodebug.exp: whatis dataglobal + 1 Simon> +FAIL: gdb.base/nodebug.exp: whatis sizeof(dataglobal + 1) Simon> So it's already covered. Tom, are these cases correctly handled with Simon> this series applied? It wasn't, which I don't understand, since I regression tested this. I wonder if the comparison script I am using is buggy. Anyway, I have reimplemented this feature in the new version of the series, these tests work now. There's one more failure in nodebug.exp that I have yet to track down - in one case, the error message has changed. Tom