From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC][gdb/symtab] Add DEBUG_DEBUGINFOD_CLIENT in debuginfod-support.c
Date: Thu, 01 Apr 2021 10:28:09 -0600 [thread overview]
Message-ID: <87tuoqq89y.fsf@tromey.com> (raw)
In-Reply-To: <20210331135644.GA13846@delia> (Tom de Vries's message of "Wed, 31 Mar 2021 15:56:45 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> +print_build_id (FILE *stream, const char *prefix, const unsigned char *build_id,
Tom> + int build_id_len, const char *postfix)
Tom> +{
Tom> + if (prefix)
Tom> + fprintf (stream, "%s", prefix);
Tom> + for (int i = 0; i < build_id_len; ++i)
Tom> + fprintf (stream, "%02x", build_id[i]);
Tom> + if (postfix)
For prefix/postfix checks, use the '!= nullptr' form.
Tom
prev parent reply other threads:[~2021-04-01 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:56 Tom de Vries
2021-04-01 13:38 ` Simon Marchi via Gdb-patches
2021-04-01 16:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuoqq89y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox