From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FjIkE+XSz2D6KwAAWB0awg (envelope-from ) for ; Sun, 20 Jun 2021 19:44:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 423961F1F2; Sun, 20 Jun 2021 19:44:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 62C571E939 for ; Sun, 20 Jun 2021 19:44:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9FA9385EC58 for ; Sun, 20 Jun 2021 23:44:35 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.193.119]) by sourceware.org (Postfix) with ESMTPS id 883AF385B804 for ; Sun, 20 Jun 2021 23:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 883AF385B804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id E8286400DA220 for ; Sun, 20 Jun 2021 18:44:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v76ylCH8ZuywRv76yl2WIx; Sun, 20 Jun 2021 18:44:20 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fTFuLmBAxozfy5lVCwYKxHxrr2FGN89SlBv6/U8j0Qc=; b=crpLsio3nhOt4gTJ5XjCkxawHe neY+ABe3Hys5lN5WPiXOLKkYpg8chy/I9bqTTpF8I00ZU/E/wEa4WRKRu4KN9iLgOOLIsTGs77mah 9mW+E3EMhIWyALFGs+z3dxQQn; Received: from 97-122-70-83.hlrn.qwest.net ([97.122.70.83]:58606 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lv76y-004FR8-Iy; Sun, 20 Jun 2021 17:44:20 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [RFC][gdb/symtab] Lazy expansion of full symbol table References: <20210614093908.GA22709@delia> <87pmwoxj3j.fsf@tromey.com> <533bf7e4-d96c-a6b7-8c37-a4141ebdc761@suse.de> <87im2fxnr7.fsf@tromey.com> <87bl83ykd9.fsf@tromey.com> X-Attribution: Tom Date: Sun, 20 Jun 2021 17:44:19 -0600 In-Reply-To: (Tom de Vries's message of "Sat, 19 Jun 2021 21:36:40 +0200") Message-ID: <87tulsw17w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.83 X-Source-L: No X-Exim-ID: 1lv76y-004FR8-Iy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-83.hlrn.qwest.net (localhost.localdomain) [97.122.70.83]:58606 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Tom> Tried the updated branch and ran into a race condition, fixed in Tom> attached patch. How did you observe it? Tom> + static std::mutex mutex; Tom> asection *sectp; Tom> bfd *abfd; Tom> gdb_byte *buf, *retbuf; Tom> + std::lock_guard guard (mutex); Tom> if (readin) Tom> return; Tom> buffer = NULL; I don't think we want to do this, because BFD isn't thread-safe, and I've been avoiding touching it. Instead I think we'll have to track down the problems spots and arrange for the required sections to be read in before any threaded work is started. Making BFD "thread-safe-enough" might be worthwhile, I'm not sure. Tom