From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/4] gdbsupport: add array_view copy function
Date: Tue, 16 Nov 2021 17:20:33 -0700 [thread overview]
Message-ID: <87tugbzl7y.fsf@tromey.com> (raw)
In-Reply-To: <90ddca61-ea64-b354-6fb4-99ab607a43d6@efficios.com> (Simon Marchi's message of "Tue, 16 Nov 2021 16:56:13 -0500")
>> In C++20 I think we could use std::copy by having the array view
>> iterators implement the contiguous_iterator concept. So, maybe a
>> comment to this effect would be good.
Simon> Do you mean we could use std::copy to implement this copy function,
Simon> instead of using memcpy, and that would deal with the details of copying
Simon> in the most efficient manner?
Yeah, but IIUC it will only use memcpy or whatever if it sees the
contiguous_iterator concept (and if the content type is trivially
copyable). I'm not sure if there's a way to get this behavior before
C++20 though.
Tom
next prev parent reply other threads:[~2021-11-17 0:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 21:06 [PATCH 1/4] gdb: fix length of array view returned by some value_contents functions Simon Marchi via Gdb-patches
2021-11-08 21:06 ` [PATCH 2/4] gdbsupport: add array_view copy function Simon Marchi via Gdb-patches
2021-11-08 21:11 ` Simon Marchi via Gdb-patches
2021-11-16 20:54 ` Tom Tromey
2021-11-16 20:53 ` Tom Tromey
2021-11-16 21:56 ` Simon Marchi via Gdb-patches
2021-11-17 0:20 ` Tom Tromey [this message]
2021-11-18 20:07 ` Simon Marchi
2021-11-08 21:06 ` [PATCH 3/4] gdb: make extract_integer take an array_view Simon Marchi via Gdb-patches
2021-11-08 21:06 ` [PATCH 4/4] gdb: trivial changes to use array_view Simon Marchi via Gdb-patches
2021-11-16 20:41 ` [PATCH 1/4] gdb: fix length of array view returned by some value_contents functions Tom Tromey
2021-11-16 21:40 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tugbzl7y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox