From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JpdcEFKyq2EBRwAAWB0awg (envelope-from ) for ; Sat, 04 Dec 2021 13:24:18 -0500 Received: by simark.ca (Postfix, from userid 112) id 395391F0CE; Sat, 4 Dec 2021 13:24:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A93AA1ECEB for ; Sat, 4 Dec 2021 13:24:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 465443858427 for ; Sat, 4 Dec 2021 18:24:17 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.209]) by sourceware.org (Postfix) with ESMTPS id 97E863858D28 for ; Sat, 4 Dec 2021 18:24:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97E863858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 72623175813 for ; Sat, 4 Dec 2021 12:22:26 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id tZg2mrcboIQaEtZg2mmuqZ; Sat, 04 Dec 2021 12:22:26 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=diAdL9e0fXFPqH7aKuddaGTGHQNWDeq1H9g/GyY5ldk=; b=lQqKMqGcofGUoJ407oQRywI9zV TY8rj633BJQz3he6FzumNHx9K4SlujL9XzIglegC7mt+ReJCobs0sA90wIMW9/11Y85hKlyVTOC3U W777P7i1MjN+JZUPbjQ9Q8U1v; Received: from 97-122-84-67.hlrn.qwest.net ([97.122.84.67]:40438 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mtZg1-002zY6-PB; Sat, 04 Dec 2021 11:22:25 -0700 From: Tom Tromey To: Joel Brobecker Subject: Re: [PATCH 3/3] Cache the result of find_file_and_directory References: <20211130013304.4135367-1-tom@tromey.com> <20211130013304.4135367-4-tom@tromey.com> X-Attribution: Tom Date: Sat, 04 Dec 2021 11:22:25 -0700 In-Reply-To: (Joel Brobecker's message of "Sat, 4 Dec 2021 14:42:46 +0400") Message-ID: <87tufotela.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.84.67 X-Source-L: No X-Exim-ID: 1mtZg1-002zY6-PB X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-84-67.hlrn.qwest.net (localhost.localdomain) [97.122.84.67]:40438 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> This changes the DWARF reader to cache the result of >> find_file_and_directory. This is not especially important now, but it >> will help the new DWARF indexer. Joel> With the renaming of the class members moved to patch #2 (I made the Joel> assumption that all the changes in file-and-dir.h are about that, at Joel> least from what I could see), this patch looks good to me. Thanks, I'm going to check these in now. Tom