From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id r57rLWw4tGNWnw4AWB0awg (envelope-from ) for ; Tue, 03 Jan 2023 09:15:08 -0500 Received: by simark.ca (Postfix, from userid 112) id A989A1E222; Tue, 3 Jan 2023 09:15:08 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=BE7VCKzk; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5EC2C1E112 for ; Tue, 3 Jan 2023 09:15:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ADAC93858C39 for ; Tue, 3 Jan 2023 14:15:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ADAC93858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672755307; bh=IGCV1GVkdWwvYBty+GML9FVxLvT+rATX9daCahF2U2g=; h=To:Cc:Subject:References:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BE7VCKzksKDWFIiA48IdQw08LqLwqU33pnfCITSLGrrEnE0WE+UpFpKy7oiYiSACc H1fIkT699oy8ZfQXooWVuub7iRUY8wfm6CGrOnbf94DsszHEUw+ypeIBy7sl0kbYUz qL83YVgulEe/C+KVHboSC1QBV48aHPubIq9MW9zQ= Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 80C863858291 for ; Tue, 3 Jan 2023 14:14:30 +0000 (GMT) Received: by mail-il1-x12f.google.com with SMTP id y2so18064742ily.5 for ; Tue, 03 Jan 2023 06:14:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IGCV1GVkdWwvYBty+GML9FVxLvT+rATX9daCahF2U2g=; b=SCkwDKVRfzG9CHXIV8Q9A99B43ctJeMZ8YGDHYl1hHnaNlQz1DS69IhYOawRv99syS 1iW9fSaARpUlyAWSbrFTaFNRnUosaeEUxdRHc1F95AqDfu+DlAJajva47DnUGywa2oDi kLzVShmyGY5mmzFL3p9QfejYUVP/JWvjFM1NM2ugJwnELq0kKgq8VtEcH1Jzv3D8k4+p jBast1ugN/mKjVTfgYUxpE3Eh07hTOKJsnOwkSIeNPsPbL2jJnZRsmgpDkgzb0VgnB7j gxc3+JSDL8LmVmnZ/wXIxj2T/JqaAvN0HsUV4zpXwlCtdiyV5lAActMqysyijPmwf4+7 d5jA== X-Gm-Message-State: AFqh2kpdz/OccJOMfTV7iTXmKTQFfCcvz8VCTwKx+VgIkMmkbBg+yqdH HNc7BhgiAD2djv0FSXH860FhT4nunffloQcE X-Google-Smtp-Source: AMrXdXtmkyFX1S74pkNezaA/3CiRsY3+vF2xPHYWVa8vMSpslEqSkIVC751IJ6p1MQ0moVNvTM5ttw== X-Received: by 2002:a05:6e02:1a02:b0:30c:67cb:3b32 with SMTP id s2-20020a056e021a0200b0030c67cb3b32mr714023ild.19.1672755269739; Tue, 03 Jan 2023 06:14:29 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id m8-20020a927108000000b003024b62725dsm9685627ilc.22.2023.01.03.06.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 06:14:29 -0800 (PST) To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol References: <20220901163059.3678708-1-tromey@adacore.com> <87bkrk8j21.fsf@tromey.com> <877d1duivp.fsf@tromey.com> <87k024khch.fsf@tromey.com> <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> X-Attribution: Tom Date: Tue, 03 Jan 2023 07:14:28 -0700 In-Reply-To: <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> (Tom de Vries's message of "Tue, 3 Jan 2023 09:04:17 +0100") Message-ID: <87tu17iu2j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c: In member Tom> function =E2=80=98virtual void dap_interp::init(bool)=E2=80=99: Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: error: Tom> =E2=80=98PyObject_CallNoArgs=E2=80=99 was not declared in this scope Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); Tom> ^~~~~~~~~~~~~~~~~~~ Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: note: Tom> suggested alternative: =E2=80=98_PyObject_CallNoArg=E2=80=99 Tom> gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); Tom> ^~~~~~~~~~~~~~~~~~~ Tom> _PyObject_CallNoArg Tom> ... Sorry about that. I'm going to apply the appended, which should fix the problem. Tom commit 5aea5eca6c873334deb41f996dec255786a6f84d Author: Tom Tromey Date: Tue Jan 3 07:13:01 2023 -0700 Do not use PyObject_CallNoArgs =20=20=20=20 PyObject_CallNoArgs was introduced in Python 3.9, so avoid it in favor of PyObject_CallObject. diff --git a/gdb/python/py-dap.c b/gdb/python/py-dap.c index 8e977bc55bb..9c77b2a4f76 100644 --- a/gdb/python/py-dap.c +++ b/gdb/python/py-dap.c @@ -1,6 +1,6 @@ /* Python DAP interpreter =20 - Copyright (C) 2022 Free Software Foundation, Inc. + Copyright (C) 2022, 2023 Free Software Foundation, Inc. =20 This file is part of GDB. =20 @@ -80,7 +80,7 @@ dap_interp::init (bool top_level) if (func =3D=3D nullptr) gdbpy_handle_exception (); =20 - gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); + gdbpy_ref<> result_obj (PyObject_CallObject (func.get (), nullptr)); if (result_obj =3D=3D nullptr) gdbpy_handle_exception (); =20