From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AAbIHcjqHWWOECUAWB0awg (envelope-from ) for ; Wed, 04 Oct 2023 18:44:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=cmcu0pmy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 75BE01E0C3; Wed, 4 Oct 2023 18:44:24 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 681071E092 for ; Wed, 4 Oct 2023 18:44:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEEC63858C01 for ; Wed, 4 Oct 2023 22:44:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEEC63858C01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696459461; bh=dSURgy+gvTHBiAzSYus03Vrzcc5qlo1i+1xPhf5LbVw=; h=References:To:Cc:Subject:In-reply-to:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cmcu0pmyIwJkzzpo/piwWPoNyxIMcZWBIoNRmi0xyIkiwHP7dWhoniotXquK7FNaN LC4rpkp96Go+W55Ug1ktQprVb1RNXqmAFgNETbCC/Uhvu2iXr1yMgBF5bk5EIDXlIh yYxjeHSIzhDLZubYyjxeA8tOkP1LwjmXvGlrUG9E= Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id 9691D3858D3C for ; Wed, 4 Oct 2023 22:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9691D3858D3C Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-692b2bdfce9so272990b3a.3 for ; Wed, 04 Oct 2023 15:44:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696459440; x=1697064240; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dSURgy+gvTHBiAzSYus03Vrzcc5qlo1i+1xPhf5LbVw=; b=EnMVfrb4I0/IxwefO5oXCc9JJqlz/tq8A1bL7v9wleXKNrIZaqqrBJYLHBNyB0bB2v 2TxsERIi5+rKowlVNVgB8dwo1WuwVWX4v2EFVW+5aVxR7CWJ+gzjCKBK8a6he25IwQlS yW8UPon/PkFlQ72wotqLeEBS8npH1VoISR2+CDSVpx4S5dplkxibfJRiOVT0Gq/7OyK2 pUXAZXCzY43K122XC/ZbbWCqsoNhzJeoV8nNZkmvjHcmwwQ/umvugMwYTC5sOTO45Pn4 DwVqorr4qOeFCWqFev34IE/iJi2c0MN/04zOgCJzSOyg+2yCuyVnJl7CCqYXYOpISOay Vbaw== X-Gm-Message-State: AOJu0YyrFqlCwBBwtBdzjhDuZqaP6L7ftoSc1MNUODekdsYMkPOXmqPM 8j3GVB7Be1geW8/SRRyW/LUHUVJBN9NUqudpBJk= X-Google-Smtp-Source: AGHT+IHWm69KigMUQpiGIFFVdVXTYmVU7X1X5LGNbt7zRdhpHspMvCaOELWrvqI7aX0lu67lDn7NOw== X-Received: by 2002:a05:6a20:5485:b0:143:f4dd:dfae with SMTP id i5-20020a056a20548500b00143f4dddfaemr4164364pzk.43.1696459439860; Wed, 04 Oct 2023 15:43:59 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:2dfa:6486:a698:5ba9]) by smtp.gmail.com with ESMTPSA id fe23-20020a056a002f1700b00689f5940061sm41150pfb.17.2023.10.04.15.43.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Oct 2023 15:43:59 -0700 (PDT) References: <20231003195338.334948-1-thiago.bauermann@linaro.org> User-agent: mu4e 1.10.7; emacs 29.1 To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Bump up 'match_max' In-reply-to: Date: Wed, 04 Oct 2023 19:43:56 -0300 Message-ID: <87ttr6m2j7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thiago Jung Bauermann via Gdb-patches Reply-To: Thiago Jung Bauermann Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hello Simon, Thanks for looking into this. Simon Marchi writes: > On 2023-10-03 15:53, Thiago Jung Bauermann via Gdb-patches wrote: >> This fixes "ERROR: internal buffer is full." in gdb.base/maint.exp when >> running with "make check-read1". >> >> Also take the opportunity to fix stray whitespace in the vicinity. >> --- >> gdb/testsuite/lib/gdb.exp | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index de22da8d8a8c..c6ee4628f8f5 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -6533,13 +6533,14 @@ proc default_gdb_init { test_file_name } { >> if { $gdb_wrapper_target != [current_target_name] } { >> set gdb_wrapper_initialized 0 >> } >> - >> + >> # Unlike most tests, we have a small number of tests that generate >> # a very large amount of output. We therefore increase the expect >> # buffer size to be able to contain the entire test output. This >> - # is especially needed by gdb.base/info-macros.exp. >> - match_max -d 65536 >> - # Also set this value for the currently running GDB. >> + # is especially needed by gdb.base/info-macros.exp and >> + # gdb.base/maint.exp. >> + match_max -d 196608 >> + # Also set this value for the currently running GDB. >> match_max [match_max -d] >> >> # We want to add the name of the TCL testcase to the PASS/FAIL messages. > > Do you have details about what fails specifically? It runs fine here, I think that what causes trouble is the fact that the line tables of the dynamic linker are huge. What happens is that when testing "maint info line-table w/o a file name", expect times out in the middle of "maint info line-table" output while it's listing the line-table of dl-load.c. A bit after that I get the first 2 "ERROR: internal buffer is full." (I get between 2 and 5 such ERRORs depending on the machine). Then there are a few more errors while printing the line table of elf/rtld.c. > so I'm curious which part of the test fills the buffer exactly. Also, Interesting. This fails on all 4 of the machines I tried, covering aarch64-linux, armv8l-linux-gnueabihf and x86_84-linux. Do you have libc6 debuginfo installed? In any case, I put the testsuite logs of regular "make check" and "make check-read1" with default timeout and with 3600s timeout for gdb.base/maint.exp here: https://people.linaro.org/~thiago.bauermann/read1-maint.exp/ > my understanding is that check-read1 should have no effect on this, it > shouldn't fill the buffer more than a regular "make check". It only > makes it such that read system calls return at most 1 byte. I don't know how expect manages its internal buffer. I initially wrote that "maybe timed out tests cause the unmatched output accumulate in the buffer?", but then I tested with gdb_test_timeout set to 3600: I didn't get timeouts anymore, but I still got the "internal buffer is full" errors, which caused the respective tests to be marked UNRESOLVED. So all this to say that I don't know what is going on, TBH... -- Thiago