From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /AueORjMcGVvTRkAWB0awg (envelope-from ) for ; Wed, 06 Dec 2023 14:31:36 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AkyKaKcU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E21BB1E0D2; Wed, 6 Dec 2023 14:31:36 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D4D2A1E091 for ; Wed, 6 Dec 2023 14:31:34 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 416B2385783E for ; Wed, 6 Dec 2023 19:31:34 +0000 (GMT) Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 944063857B99 for ; Wed, 6 Dec 2023 19:31:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 944063857B99 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 944063857B99 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701891083; cv=none; b=L1qgzkEVNxgrOH4GLwWXIK/ZNFqV+BgRx4b6yxnsVXwfkwqIQoTUCz0dDNaEApYzi6YegWxhXpW/tuQ8acL21kaebzQfj4CRxjzjYLncYS0rphcZlEYjd7HlBu+kbCuV0j/YH59cpKWJCOWVzozI4dMe9/OH6KakLlwy5spez0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701891083; c=relaxed/simple; bh=exHRGheTzv48FfX2diJLk6Q4dn0TWNabgg61kx/52aE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Xnw7Xu6ZjdzFB2SMJhLN1iHYIHVbEx4CAab8cW7vcXGPXCENEZg1mxXr8jQAx98NcAYAJBfinoZRa/m/42QJYenNIRSTEp7CzpznRfF2KACBKswbZxRMpjGh9MtB66MVtotXsO/vm1rdrZUUEONLzEv8pBx3oFbT3fP4veAp/1M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id AohJrBUP56nOZAxc7rMxLe; Wed, 06 Dec 2023 19:31:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Axc6rkMN38vT0Axc7r4txl; Wed, 06 Dec 2023 19:31:19 +0000 X-Authority-Analysis: v=2.4 cv=ffi+dmcF c=1 sm=1 tr=0 ts=6570cc07 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=yZartn1kFYwWe9IAEGQA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GqsN31rc5F0tdjKMlLWRdzSk28GiguTl02Mu8dX9om8=; b=AkyKaKcUdPsZPpcke1rQPIcVNp Xn5wDWOsRgPXvWr8yv7EZRw5a7zKhUcvRarE6vfbSZqm3Xr7m0LlLBTo0WO2aiX/7PF7FqiFm5lgK 0C8CBUTJdahOWdftyo6BlOGUn; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:55076 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rAxc6-004Iqi-1E; Wed, 06 Dec 2023 12:31:18 -0700 From: Tom Tromey To: Hannes Domani Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix DLL export forwarding References: <20231204165029.408-1-ssbssa.ref@yahoo.de> <20231204165029.408-1-ssbssa@yahoo.de> X-Attribution: Tom Date: Wed, 06 Dec 2023 12:31:17 -0700 In-Reply-To: <20231204165029.408-1-ssbssa@yahoo.de> (Hannes Domani's message of "Mon, 4 Dec 2023 17:50:29 +0100") Message-ID: <87ttovi0vu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1rAxc6-004Iqi-1E X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:55076 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN7t5by3YlAL+ODCiIwjtbSq0ea497ziRbtGYVSYnc+oTOzSAr9SJzjYT54QAAjHkOSBkNF9wK852dzrl89S7XYTj/nQqjZd8iSi9lLiLZYmPLc8BNr4 Xgy4H4yEX8yUI4XOXXzK4INCv8wenNO0e2F2agWbhDgCxMY2lXPYk8l+/jYQYj/fRsUfO/VS8PZkc9pZCPCzZmE5HdzSwctgnaY= X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Hannes" == Hannes Domani writes: Hannes> I noticed it when I was trying to set a breakpoint at ExitProcess: ... Thank you for the patch. I have a couple of tiny nits, this is ok with those fixed -- you don't have to re-send it. You can also apply this to the gdb-14 branch if you want. Hannes> - unrelocated_addr vma = msymbol.minsym->unrelocated_address (); Hannes> + /* Calculate VMA as if if where relative to DLL_NAME/OBJFILE, even though s/if where/it were/ Hannes> + it actually points inside another dll (FORWARD_DLL_NAME). */ Hannes> + unrelocated_addr vma = unrelocated_addr(msymbol.value_address () Space before the first "(". Approved-By: Tom Tromey Tom