From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IH6RJc6FImYm9jQAWB0awg (envelope-from ) for ; Fri, 19 Apr 2024 10:55:10 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=LXtMznJq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 94B6D1E0C0; Fri, 19 Apr 2024 10:55:10 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D5BA1E092 for ; Fri, 19 Apr 2024 10:55:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 185233849ACB for ; Fri, 19 Apr 2024 14:55:08 +0000 (GMT) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id B96C93849ACB for ; Fri, 19 Apr 2024 14:54:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B96C93849ACB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B96C93849ACB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713538486; cv=none; b=JxgvBxZpTnu+moyDo6YJKkHWYk1wgO40AEyIgv067aQEVN1JqzDxs2m3XoxGZn7JXglZVe9mXAhq5ssdH9mOO1O7WUJrcqVRoMKDPgP/Wr7r63gg2nJdKQBtCSBEgwtF7bRwJ3WlsndPvb2Nyk9KmrBjdPH8H2eyLEAQpzyhI1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713538486; c=relaxed/simple; bh=FhC1pNEPFOXdOB0T50yJs6aDOEA4PmN9PnqJ8aWtgWg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pzW7usOL+Pp4yph56Efg+vVvbEvE128tCcKZZiPOdfI7wyzT7b0ZI9ibtQKIkLgRvgU2OUvxsP4dcWvk+aJtYSAc7SQv3T0rxRVeg4ePsYgv/QBRf5wD5zNMRC19b7eY5aw4wLyN7JG3S01l5cDDQGGX3zLAL+V44/KdJTme7rg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7d6b0c766e9so75634739f.0 for ; Fri, 19 Apr 2024 07:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713538483; x=1714143283; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bDazj/zZdQ/yHf7M++1+pXQowQ+32bBFQ+nD+ATawKk=; b=LXtMznJqaa5YSyjm3uX6yMYNByTp2dWLCHsEhQV39ofAX7IiF9IpSsqdRA/GbbQmEK BQH3jqqrHp3YwS3xoFBDU9zz77/yLmSm14fHb09p4q6cVGzDdkJa0XvhD5osgzuqYr7k uuIZ5I9nOa4JPEXPx90yj9JEXFS3AN/6gZ3LeS9Y8Dn5W+rLxOC5uK0jtUqu5bqLM+1x tF9gb6oXKA0kNWXjFk7szMX02CaYw5xb5S5deeidWBxy9mfEC+CA9t0zlx+NsW9jFx0G peohU0snDJCi2WFNiGp43B/PONZNotWEybyAQKoCMpGxnHKfXjAFRAIuhn+WpcauZGAj tNTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713538483; x=1714143283; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bDazj/zZdQ/yHf7M++1+pXQowQ+32bBFQ+nD+ATawKk=; b=oCv4Yec7BVUseov6lJuZ7d+NQDMhRsUOYwQ+z4qteBEA6/+pRjZTBbR6FgT9HywGYJ GTUM9h5etxHraVnMQHg3Q38c3VrbT5L8h0+NcGRF0Upi4pWjfeeP7UAcE6rIdiB+nPAt LI0I7dxhfV/BLdPDKaqps7CVBHbEF/itWYPmNeMhPAA83KyELpca/bAgEr6vK2DoxN+g BA5tKVJPfEazhjVDL23H2ZekXuXZkd0ntHxOdq1dLFnjvJvML7W8xp/64Nx0tTO49RnT M/4GPgQ+LQaS9GZyRG+Adm+/+9116bpxlDaSxWU4hpvGusxq/Hv74CpQSpVeIoymplHp C2sQ== X-Forwarded-Encrypted: i=1; AJvYcCVB/oGlbm25YwVevbiLl7kHWxGkrHpHpIiY15IXMNuQr+RspBSy8bx9RxjQZNcgHVcanQe2QIP6AGC2puzr2QesFAjAgrnRy1QH2A== X-Gm-Message-State: AOJu0YwxTx8jXdOvhknYQJNU/m+2YkNEDnwpYcBgBSSQd50a2K7j4z5Z 57qDCyA52u4toZ0v/Y+TOmtluGvzPm2lDV7ckoUm78JojWnWwaEmkpd+hEVjcA== X-Google-Smtp-Source: AGHT+IEYVcLtZNXzE8V/JbDjnW7KL9/iYuMWG/P/3/9Rf+1/vg1NWfMHMqVJqYCkEr4+Lliu7xGAmQ== X-Received: by 2002:a05:6602:6d0d:b0:7d9:633e:8cc6 with SMTP id im13-20020a0566026d0d00b007d9633e8cc6mr3293622iob.6.1713538483000; Fri, 19 Apr 2024 07:54:43 -0700 (PDT) Received: from murgatroyd (97-122-86-252.hlrn.qwest.net. [97.122.86.252]) by smtp.gmail.com with ESMTPSA id co21-20020a0566383e1500b00484ec1886cfsm68505jab.6.2024.04.19.07.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 07:54:42 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/4] Add an include-checking script References: <20240418-header-check-v2-0-725529851603@adacore.com> <20240418-header-check-v2-2-725529851603@adacore.com> <6b1239d1-c20a-45bc-8f5d-34b95e17f5c8@simark.ca> X-Attribution: Tom Date: Fri, 19 Apr 2024 08:54:41 -0600 In-Reply-To: <6b1239d1-c20a-45bc-8f5d-34b95e17f5c8@simark.ca> (Simon Marchi's message of "Thu, 18 Apr 2024 15:25:36 -0400") Message-ID: <87ttjxxv0u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >> +def headers(dirname): >> + return glob.iglob(dirname + "/*.h") Simon> This appears to be the same code as in v1, did you forget to commit your Simon> changes or something like that? You replied that you removed this Simon> unused function, but here it is. I am not sure what's happening. The function is definitely not here. I wonder if this is some b4 thing since I modified the branch in a weird way. I'll try again with b4 but if that fails again I will re-send the normal way. And I guess stop using b4. Tom