From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rZeQJasLkmgfcwQAWB0awg (envelope-from ) for ; Tue, 05 Aug 2025 09:48:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bczUFuUD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 854AD1E102; Tue, 5 Aug 2025 09:48:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E31C1E091 for ; Tue, 5 Aug 2025 09:48:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 176CC3858410 for ; Tue, 5 Aug 2025 13:48:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176CC3858410 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bczUFuUD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1D86F385840E for ; Tue, 5 Aug 2025 13:47:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D86F385840E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D86F385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754401671; cv=none; b=sMxxCBV07f5PpBBag+cqUoyVb4qu/WiDHNWQMSyF33eO8g8K7W447qZZ0EyZwQWxHx9HziAidXuvSNWFwK3MPrhjaIiT34wKORCM2/1+bNb6XLWzybqVB1BZGMM/2QnCHSXIsbJuVnODZj84eUepTS8sTkQgUqtwgQvFV6eKBEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754401671; c=relaxed/simple; bh=G6AXzmlVpiN8VMX95fA874kWknLev4Ec/YWJiZcDOcA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AXSz3U52gJn7FA2KKZE2AGIh5nz1cOsYP7gl/ZlUZhzy/XJNyxvPAgHGyLZqdHNOqBNzho+H7k+RIbD5imvpTenoIuA/j9TSjpSRP/wA9ZGqIjGLv25okov5aQH63aFAWVMiTcYq5Ba7L5E5zLOachHpBT4in4MprmnnUWK8O8c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D86F385840E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754401670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Igy+isQLR0/P6dgS20yrvg3/K1QGZNIZE7wu/8Cbl+A=; b=bczUFuUD8npqEjXoMFFqx9hZH9SHSu/Aw9jYc78DMV6J7VkPu4STU7o+H9WEoW/LB3DNB4 fkmZDI663tjnMK6hGYXM/vkuI8Gn13fDODR7JuRU4WmmKmgimHfOwcIsFUik/9RH5dk2qM OqsMAHsMNTeybmOD6qH36p3ld0aFVAw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-wuTvidpCNy6gHWD9cNOY3A-1; Tue, 05 Aug 2025 09:47:49 -0400 X-MC-Unique: wuTvidpCNy6gHWD9cNOY3A-1 X-Mimecast-MFC-AGG-ID: wuTvidpCNy6gHWD9cNOY3A_1754401668 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3b81e16c17dso1971430f8f.3 for ; Tue, 05 Aug 2025 06:47:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754401668; x=1755006468; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Igy+isQLR0/P6dgS20yrvg3/K1QGZNIZE7wu/8Cbl+A=; b=xDlwrLMoXL3QHdvNorHlYrF7QGcKE83kTJeJIq9dPTOfu/0aZnNH2y1MDRCSFje3/A V0CucENpeTxD16te5z04ID2eiOO7nCBihnXpB1LapRqCjSN5aEDj0W1NW1zx2bOS8MhQ iP1KjgGMtpqafTaXOg+pfl9Oa5svgvEzEmNiakkwuVsdvoPn7sOnsJylWk16V9mn9TYL U+HpuxP6WZeD1QAglBUlNNTY5mN5wTy6/XkQVyyrjS3yYKu4PcVn5I9JJ2Ln/vhTvK93 HMVkF//iIiiJgf4Bc6REIUZKaLeRmwkvCnXeRzY+p9TkUT4QH+zFX8oyeCbtjjkvsP6r K3VA== X-Forwarded-Encrypted: i=1; AJvYcCXKW3UPeYLlui+gX3Sts90BnpyjY5OWBd6LmYpQhwMUyyuy2NjZTNKxx3cfQwUTe342GrgQAAZYBNf8hQ==@sourceware.org X-Gm-Message-State: AOJu0YyceOsjCedwa5sHyuGFpc3QNdd/D1bYFWuV2SZm3pI8qw510f2k WJsLYvJpYseEyEu+8f9LizXbPBIroAmSd7XlZvZbpyTcL6FJw44r5/cj05o3FP8Vj/wwDNx24/x zsQ0jZSMfGC7SGcOa29gGxEv4nIj2JqsRQ6pQQ9yMG8q66Zpbll3J4I9t+v0saxE= X-Gm-Gg: ASbGncuVloVHIcgnJYlJ4eXtA/f7BQmKBU+MCMPSgQbiysTrVL/6UFsZhdmA8HuHTdZ VouZnQ2OkPsFFph+BWEf9irQoNWwlVHbq36ZA94tcO/0x5GNXunVqQzsRst87FykvrunBVT6KpW JdkovOgJ2UO/JX3PedrA78rt/DHyzgsBbDEzKIONgD475gRLCjdghGiRk5ni0WB3qpWTTIfiw8h +UiL5zIUXJUR6x6eaWYKXsFYJ6fTqZ1D0a/F99iNwmZrEoUQdvG0jHyvGA42mAEXJpkAr6AyPvq 9v0E0KLpNCqBloWNMR8trPFSXzQiZ1Q1sl4fbeTIgZ/nEYjrHkRGXF5/TWo= X-Received: by 2002:a5d:5f87:0:b0:3b7:994b:8409 with SMTP id ffacd0b85a97d-3b8d94ba170mr10228446f8f.39.1754401667747; Tue, 05 Aug 2025 06:47:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3Bu86RMnNXfa/9U6OwPYzB/OaMRGZSM7iZJK0mP1WrzkytPQME/em52E9cPXSkXDdBH+5BA== X-Received: by 2002:a5d:5f87:0:b0:3b7:994b:8409 with SMTP id ffacd0b85a97d-3b8d94ba170mr10228423f8f.39.1754401667314; Tue, 05 Aug 2025 06:47:47 -0700 (PDT) Received: from localhost (27.81.93.209.dyn.plus.net. [209.93.81.27]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4589536acc9sm256909725e9.6.2025.08.05.06.47.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Aug 2025 06:47:46 -0700 (PDT) From: Andrew Burgess To: "Schimpe, Christina" , "gdb-patches@sourceware.org" Cc: "thiago.bauermann@linaro.org" , "luis.machado@arm.com" Subject: RE: [PATCH v5 05/12] gdb, gdbserver: Use xstate_bv for target description creation on x86. In-Reply-To: References: <20250628082810.332526-1-christina.schimpe@intel.com> <20250628082810.332526-6-christina.schimpe@intel.com> <8734aynam5.fsf@redhat.com> Date: Tue, 05 Aug 2025 14:47:45 +0100 Message-ID: <87tt2lani6.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1pt-gu70m5MSGiLK2fAgjbCn15uwXriHCRcQcjEUAo8_1754401668 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Schimpe, Christina" writes: > Hi Andrew, > > Do you have any final comments ? > My plan would be to fix your comments locally (as described below) and push the series by tomorrow. > Or should I repost this patch to be sure? > > Thanks, > Christina > > From: Schimpe, Christina > Sent: Tuesday, July 15, 2025 12:28 PM > To: Andrew Burgess ; gdb-patches@sourceware.org > Cc: thiago.bauermann@linaro.org; luis.machado@arm.com > Subject: Re: [PATCH v5 05/12] gdb, gdbserver: Use xstate_bv for target description creation on x86. > > Hi Andrew, > > Thanks a lot for the review. > >>> The XSAVE features set is organized in state components, which are a set >>> of or parts of registers. So-called XSAVE-supported features are > >> Maybe here you mean: "..., which are a set of, or parts of, registers." >> If not, then this sentence doesn't make sense to me > > I agree, this sentence is a bit confusing. I think I would prefer to write it out actually. > Is the following more understandable? > "The XSAVE function set is organized in state components, which are a set of registers > or parts of registers." > >>> The SDM uses the term xstate_bv for a state-component bitmap, which is > >> Would it be possible to define what SDM it please. > > Do you mean writing it out to "Intel Software Developer's Manual" ? Yes, just the first time SDM is referenced. Ideally these commit messages should be written for a general audience, who might not be familiar with Intel acronyms. >> I'd like to ask about the use of 'mask' in this variable name. We used >> to pass in an xcr0 value, which was then combined with various masks to >> extract the state bits we were interested in. > >> You've renamed the new variable as a mask, but continue to combine it >> with the same masks (e.g. X86_XSTATE_AVX), which makes me suspect the >> variable is not a mask at all. > > It's not a mask at all. I honestly cannot tell why I decided to call this xstate_bv > instead of xstate_bv_mask when I wrote this patch... > >> Now, I can see where the confusion might have come from. Almost every >> call to amd64_target_description passes in a *_MASK constant. But >> that's OK, given these are bit sets, then the MASK constants actually >> define valid values. > >> I am aware that this sounds like a trivial complaint over a variable >> name, but I think calling this a mask is pretty confusing (at least to >> me), so unless I'm not understanding this, then I think it is worth >> renaming this. > >> The use of `mask` for the value is present throughout this patch, not >> just this one function. > > I agree and am glad for your feedback here. > The current naming is confusing and I will rename it to xstate_bv. Sounds great. Thanks, Andrew