From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fk73IEXbAWkNXw8AWB0awg (envelope-from ) for ; Wed, 29 Oct 2025 05:15:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UIlSpWPv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 79D181E057; Wed, 29 Oct 2025 05:15:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C6801E057 for ; Wed, 29 Oct 2025 05:15:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34CF33858CDB for ; Wed, 29 Oct 2025 09:15:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34CF33858CDB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UIlSpWPv Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 905F03858D20 for ; Wed, 29 Oct 2025 09:15:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 905F03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 905F03858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761729312; cv=none; b=nwHe+JAmxAj4nL2+SC1051L3X6Jm86Z08P3hKXWJhtIPxI18/Vk0ZhoZTD5JX6mU4POsUsg738w7BDx+33f3FDXSUYTV4UYRV7vYfH5AZhA/wx4hWDs7bLBe4+4/rC576BJoJCnGGR/F85i8paIKE2h8ouDjW45Wq0RIFSIjlWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761729312; c=relaxed/simple; bh=LCsxGROtWR3dsLHoTIpjf0mfucuaY/PyP07xTV7lRvM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=amGNvOVsrz+jNhbqORwbJBrA4nufnuFRcCh/YeOzZDcXOhl8RKBMbjZ7IJnVdF4ii7HvlPciY0hyUCgYtKcBTnGrTFeh3OVoIiWO0WkHZbfTVEJj//uSFayfV9rZTWefdbv2QbU/V4jK4gEprgeXwvoE9IDmsNWbmXscWjrDyVo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 905F03858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761729311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PncC1MGNLDGxrntR5J3Co7A3dbG07NnSrTvqA7X8xpE=; b=UIlSpWPvPnJKWuL8a4dUD7uDDYij++23m6uNtr3qK0/KypelfIpnWKaijXFLPFUHf1wART oV4kHoaHu3kOjipS/KtlN6npKNBKV90FSMUlceLrpud49y+1+4BkflO2zFS226/ONLI1ke ry/GUIwfLCeNL2RsDWPmxSrnmUQcFEE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-ddgq0aCuM6uiXHHJ97LlGQ-1; Wed, 29 Oct 2025 05:15:10 -0400 X-MC-Unique: ddgq0aCuM6uiXHHJ97LlGQ-1 X-Mimecast-MFC-AGG-ID: ddgq0aCuM6uiXHHJ97LlGQ_1761729309 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4270a61ec48so5798228f8f.1 for ; Wed, 29 Oct 2025 02:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761729309; x=1762334109; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PncC1MGNLDGxrntR5J3Co7A3dbG07NnSrTvqA7X8xpE=; b=gecXIXisBKt4viXZreUjdfUdt4pzQH/GQHpNucmH+w6petyRTJH+2Hhomzg3iQ1Wrm 4NgJoOYejFdXH7p5ggYkE3H/YDFmYClMT7Q8vMDeoWWCkQF/6zwRtAySZDKXZjjuVb14 XAjp/T7wnWnSnZVwia1kzKoV7EiUeFtVudoEa1lSLiCgw/nkKJjufMuFJ2yYN7CDewjF kSbQQrwCCw5jy5yIc/UUsXJsipSZCZsqnt0kr8OGkjVQAVgN4wy6J70FNbznAhfCxKSC XlWVlFezpteJs/QcCfmpAMVC0WRNr7lfW2gDm/r2IpRzvDzj8Vbs+CKbB19aWm6ezd63 h7MQ== X-Gm-Message-State: AOJu0YwH1wpjPrhzNjX3IAWj+WgsHJ+0dNBoYZBxh7BJUnhMi+Ymw3A6 2VLMqOCY+IjtoBS0wuXVjKRvFFs+HPfVx3UxHyXI2yn/+uMJ5SAX9jERHFoAq0YiPojGpYWHAor VzLvWDjYadtDIQI6/jSWBpNH/HBpmokgu06yZWpRMI6zi+lkBqK/9H9wjWqrhYIc= X-Gm-Gg: ASbGncvnb5kIEeZS853amdTEs6WADnI/drLxK5trMzQKkre80IdSsjN+9kWMRwfOzFZ guy/FezsoKyHcRQz0yej+8SbRpJdYIlhQljfFbcbeNWukHok5mnKbkiGfbDYd5IMK9y+eEMNkm9 YQrDCJ1G/EnV+obfh9Ga+zEmh2zDKPjEe2jdeBwD8wgjSEE/JPP8Rs7eTHDPr4mVz/Rvyy0h1FH n0iBasEnuXXC/iJhJgkzVi4DesxdQ5geh/e0I4bmsiwTes52NJ253P2gt+njRO6B8pvlNpSrl8M 6+yjjFli42hgOFvjnSN+xSmusC5EaJ6yc13f+C8hN4inRbUcq1NXX+oMboqU8I8IzoghNA== X-Received: by 2002:a05:6000:230b:b0:426:fd06:6b98 with SMTP id ffacd0b85a97d-429aef794c4mr1751188f8f.14.1761729308679; Wed, 29 Oct 2025 02:15:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLljsjZfqy+tJhRxDdIFDs6wwbsOk80WsGAo9kxc9EJPCDzwkz2dKaa892Joq8EZwCyL2ebg== X-Received: by 2002:a05:6000:230b:b0:426:fd06:6b98 with SMTP id ffacd0b85a97d-429aef794c4mr1751155f8f.14.1761729308210; Wed, 29 Oct 2025 02:15:08 -0700 (PDT) Received: from localhost ([109.144.18.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4771e39380dsm36004425e9.7.2025.10.29.02.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 02:15:07 -0700 (PDT) From: Andrew Burgess To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: fix git repository check in gdb.src/pre-commit.exp In-Reply-To: <20251024220953.03422a3d@f41-zbm-amd> References: <5fa8de4b2b28278dbc3bf4ae78709ee9e71c3aa0.1761340690.git.aburgess@redhat.com> <20251024220953.03422a3d@f41-zbm-amd> Date: Wed, 29 Oct 2025 09:15:06 +0000 Message-ID: <87tszi5asl.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5ZGZiT-w3kVBboQFW4EYRcvxErs-aNIF3Q9ThSdstNA_1761729309 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Kevin Buettner writes: > On Fri, 24 Oct 2025 22:18:19 +0100 > Andrew Burgess wrote: > >> In the recently added gdb.src/pre-commit.exp test, we check if the >> source directory is a git repository like this: >> >> if {![file isdirectory $repodir/.git]} { >> unsupported "Not in a git repository" >> return >> } >> >> I make extensive use of git worktrees for development. In a worktree >> .git is a file containing the location of the actual .git directory, >> it is not itself a directory. As such, the above check fails, >> claiming my source tree is not a git repository, when in fact, it is. >> >> Fix this by relaxing the check to 'file exists $repodir/.git', which >> will cover the directory and file case. > > Makes sense to me... > > Approved-by: Kevin Buettner Pushed. Thanks, Andrew