From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aXHcHKYhL2kfDxEAWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 12:28:06 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TX/GkVNG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 71E481E08D; Tue, 02 Dec 2025 12:28:06 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9E0521E08D for ; Tue, 02 Dec 2025 12:28:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2D2664BA23F0 for ; Tue, 2 Dec 2025 17:28:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D2664BA23F0 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TX/GkVNG Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id E46654BB58DC for ; Tue, 2 Dec 2025 17:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E46654BB58DC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E46654BB58DC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764696422; cv=none; b=C387wb4t+X/WSmZVv16kEhqu91H6njdT59CoBQk38s2tQzJiElKTIeWvtDRGa1MpnWggnm79BCIIHMTA8it0oyMk+hXi8SpG2G1sGC38B6hy0yQzE29abQQwSdA/lpTkpShBQACVFpYGAY+VJUL7qvFdeUH3inKf7BrLH5nHIGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764696422; c=relaxed/simple; bh=WCg9/YSMDivAyykZLqeDeW6HnF1sIMB9r1hBqMidt58=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=K8yexGk53cJL9+iZbyKglsJWFF4Pf9tk6Iy5/AvawT8lq4sPVayzQy2TYsA+lMp6OYAhD7uGKbbsyo+1b/v6wMwq4LjSQfHGEbmptBZBiLrszNxcjekI26d7SrNlBIdd6lteGGKc/L3hFSwNmOhwgSPQXxx+i7T2Lf6NuHMIQmQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E46654BB58DC Received: from eig-obgw-6003b.ext.cloudfilter.net ([10.0.30.175]) by cmsmtp with ESMTPS id QSopvrQATKjfoQU9UvcBah; Tue, 02 Dec 2025 17:27:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QU82v1HdKhoT4QU82vfJVW; Tue, 02 Dec 2025 17:25:30 +0000 X-Authority-Analysis: v=2.4 cv=XZyJzJ55 c=1 sm=1 tr=0 ts=692f210a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=wP3pNCr1ah4A:10 a=ItBw4LHWJt0A:10 a=TDl5R864AAAA:8 a=zstS-IiYAAAA:8 a=ez_XFSEvinTEsdOlUf8A:9 a=4IKI_MBedZsHOhguCAbN:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WqSnNh6o118FvZ25EHUlY52bhzVlfrFEOHXLGpMgKyE=; b=TX/GkVNG5mW56lZx5InM5jnSYL HiCQIs9mVBK4wXf9aRCVJIUB4rtKNA2glZjL8WGc5i1iZKvqbjJlwx1mrKoSgEGr2n/vPHVaWRgFt KQKptVYdgK74wLM2j/3AfTlL8; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:56478 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vQU82-00000001kwK-0Vtr; Tue, 02 Dec 2025 10:25:30 -0700 From: Tom Tromey To: Jan Vrany Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 01/13] gdb: reimplement readnow_functions::search In-Reply-To: <20251124195535.2116845-2-jan.vrany@labware.com> (Jan Vrany's message of "Mon, 24 Nov 2025 19:55:23 +0000") References: <20251124195535.2116845-1-jan.vrany@labware.com> <20251124195535.2116845-2-jan.vrany@labware.com> X-Attribution: Tom Date: Tue, 02 Dec 2025 10:25:28 -0700 Message-ID: <87tsy894on.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vQU82-00000001kwK-0Vtr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:56478 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHOyhheOC7+T8jSaNrz+irzvQrSRhokMTeinWRRlDUpeOTylf6LeJDYgoenmfiaa8pgA5BtyQ6WdulPe/G1/RVT8oySt/mp47hxsJcyZIXKyvQrezyo9 BYgfEF76xvIpZURttRR3DAlnZ0rrQguZ+L+1CBiXMJRWBdkPyhRl643NJnOqUgjziLOv7bzZLllrFGCUOEY36XqQxLDneFIEalM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Jan" == Jan Vrany writes: Jan> This commit reimplements readnow_functions::search without using DWARF Jan> data structures. This will allow readnow_functions to be used in other Jan> cases, for example in JIT reader. Jan> I was bit surprised to realize that original code did not use lookup_name Jan> to match symbols at all, and this calling listener with more CUs than Jan> needed. I did try to use it as described in the comment but run into Jan> issues (test failures) when completing symbols so I decided not to. Jan> With this change, running all tests with -readnow shown no regressions Jan> (on my Debian, x86_64 machine). Thanks, this is ok. Approved-By: Tom Tromey Tom