From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tvFGLmpJl2mwqAEAWB0awg (envelope-from ) for ; Thu, 19 Feb 2026 12:33:30 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MvIFwdr6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A32D51E089; Thu, 19 Feb 2026 12:33:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C04E61E089 for ; Thu, 19 Feb 2026 12:33:29 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 432D84B9DB61 for ; Thu, 19 Feb 2026 17:33:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 432D84B9DB61 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=MvIFwdr6 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 5B4AF4BA23CE for ; Thu, 19 Feb 2026 17:33:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5B4AF4BA23CE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5B4AF4BA23CE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771522380; cv=none; b=pn+TBibaMczn3cgbLQKTLn25M+eCpWdrde8g75KUceMLAjaN0O12xpuS7QxUR58lzyqjy6lrKIH1mxHC6OrCu2jvJ/85NkUVKFh20jTP91XwAE5Vuz9bv7HXiD5MXEOp/21Sx2tyr9DXvacvM7GjWHxKEx/CNBRwNjVVnDF/siI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771522380; c=relaxed/simple; bh=09hGgM9zNgbb3KMN/TiBh0j8ZJT9KXDoanrdcEkK+AA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KjqQCYXnbvC++Cdd+nB7rPE5lEBVRLRdYmoPbsdSWvSYvabml7Si0PHn6MLs9Eg1tJhuJia7IuTANbajkB/tQ+ydyP+Tkg0YhgkMdAwG0RiKOXWNqmM8MExAT8RDoy3gFIKmSDkaNL3xAp9U9GHunVZdCfkIdakU/WFzarPXmYM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B4AF4BA23CE Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id t2hPv3QuvKXDJt7tbvmbp1; Thu, 19 Feb 2026 17:33:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id t7tavhqB1PL32t7tbv1K5y; Thu, 19 Feb 2026 17:32:59 +0000 X-Authority-Analysis: v=2.4 cv=MqhS63ae c=1 sm=1 tr=0 ts=6997494b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=s6llwAaEQOB5qF-ibeoA:9 a=zZCYzV9kfG8A:10 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZSAs+stb72EQJ6Eo/K+mMkrq6VspN6daGwOIbHSS/7I=; b=MvIFwdr698/AJbevauOVkuwkZB 33YVAJyu/xMI01IgKv4woMJ8Mao3fAteCX1tTuAqJdosJuq6aD7EDpvsvuqo7Ihs+Vl/eBNiJos58 4oWgaq1sSQ6PmmdyMaPHGEkCy; Received: from 97-122-122-234.hlrn.qwest.net ([97.122.122.234]:59586 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vt7ta-00000001dmD-27EV; Thu, 19 Feb 2026 10:32:58 -0700 From: Tom Tromey To: Christina Schimpe Cc: gdb-patches@sourceware.org, thiago.bauermann@linaro.org Subject: Re: [PATCH v2 4/9] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c. In-Reply-To: <20260123080532.878738-5-christina.schimpe@intel.com> (Christina Schimpe's message of "Fri, 23 Jan 2026 08:05:26 +0000") References: <20260123080532.878738-1-christina.schimpe@intel.com> <20260123080532.878738-5-christina.schimpe@intel.com> X-Attribution: Tom Date: Thu, 19 Feb 2026 10:32:57 -0700 Message-ID: <87tsvc63li.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.122.234 X-Source-L: No X-Exim-ID: 1vt7ta-00000001dmD-27EV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-122-234.hlrn.qwest.net (bapiya) [97.122.122.234]:59586 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN2SqUjYsRfrCZJ7t4mySZvqwrdl7viwzNt1zFauGWxqU9/U0JjiVLwAlPX4Iojk+7w/vXwswsqe6UfbYtZEiv8osNpwCJZyCHM5nI6vEAkfQALUzt6f pC5qRbbd9KvnzHaCbC3VJiAYSjOZ3MdKoQyRrTnCdzC1o0k87Y33umhdtV0BYr3cj/bbj1sAu8JEb/Df7VaCyAOAU8Xh+VWfnFU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Christina Schimpe writes: > To avoid code duplication, create a new function 'stack.c:find_symbol_funname', > which will be used in 'stack.c:find_frame_funname'. The function will also be > used in a following commit. Looks reasonable to me. Approved-By: Tom Tromey Tom