From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GdRpJ1lInGmdIAcAWB0awg (envelope-from ) for ; Mon, 23 Feb 2026 07:30:17 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=A8BYAJC3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9C17E1E089; Mon, 23 Feb 2026 07:30:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 186571E089 for ; Mon, 23 Feb 2026 07:30:17 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3975A4B9DB79 for ; Mon, 23 Feb 2026 12:30:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3975A4B9DB79 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=A8BYAJC3 Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id 52E4A4BA23CD for ; Mon, 23 Feb 2026 12:28:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 52E4A4BA23CD Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 52E4A4BA23CD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771849723; cv=none; b=r1F2W5YQLG37QdcJZOvZkCS68wppPGs7RsC1KYL9TdyGvyy0SZpkOTTXKNCKMh3FNLB8+xHpAQJ5rMxn/yzWLivz9Yr+qgqbmRheimJvSi8VXvpNjf+DpSb/b666TLidm3TbiTve8uYU7lgyHEbo93EHZ/++IzmCrCJlkUumNxQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771849723; c=relaxed/simple; bh=NpnCNBz0twHPOGbxpKS3nxcAZEgh9xu68CLuUCwbYB4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BwbBu8zo0E2dT4vDiHFt8QJIjSU9JItV0rBn4Gdxn0hauKncRYYothhwtnyucs5iJW+0ZXbyhmBAK2diEm9/+N0oPCqM2LqvqouypUnsHa1uebP387+UlcHXfVQ2/o2LN9tzvqNmuUYXZTA0p8R3wOIq4O7Xrv9GqypoNoP7PgA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52E4A4BA23CD Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-40ede943bf0so2535065fac.2 for ; Mon, 23 Feb 2026 04:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1771849722; x=1772454522; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=w0ql/ia1Sw1mgufsabG7hAOnVBJWvbFA8AKc95YFgzE=; b=A8BYAJC3TRFgsxY3rgFm/HJtjxysH72Qp5BRAb6qSVAddTBe0dzWsD7JkBY9aZpGFi LIG5yjNruRTXIWw8ahTCbc9V0HdFnxAGnMHkdCNokVbLTBG4JHwzATXS1HHRPzwAHD5n +aw+4fAfxE6JjJXd/JkhL5N/ecAACp9pBjp6uW8mgnOwzVlYzhtW5aqE8CfGqdibKyvU 2ukRtNQRSRq4dENNrAbaN/i0JRscpENPXaQrt2MVAOgjNYIuCiltF/4qdUmsHZO2bOEF dEvMBO+HHIWTFBs8UJcNdFJZaRiqef4q7kmiECuJzze26iFszF2fc2X3wAUjGIZZaZTq 2nrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771849722; x=1772454522; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=w0ql/ia1Sw1mgufsabG7hAOnVBJWvbFA8AKc95YFgzE=; b=tHLSG53wNTusyLGWIlG8nbuEc3ONI7D/4UUvutXN/wIjhc45jSDWSVlyYVdUzjABt0 PRwMhDsZ/gv0GqmOnfQUVTPZu0g3NF9D98qw0ZrA/zQCZ61WzGYqPIuEc7dek1SyGYVs WcLqUTiX4ipTniISd6CZ/M4CgKitfKmtIZfBJQv3A34eRibmgVy2faNVnkWkh2G+stP5 MB7lFwaSxhf33BKejYzhDQkpP73Ih5kgXW2AmAuMD/dDLBV9u3roVEygLBHyeu6GGQJh s8RBvHrRhGjpZVUpxVjIE29y8wcXHl5ehzWfpQ3mo3KcjK2vNIaFWVO1ZKwJJRoWlGx7 uB+w== X-Forwarded-Encrypted: i=1; AJvYcCWAdDJFi7JRekS6wJLusMG3WUpzeYUp1zIWm0UbCRZOZEZk+qq/twJE/bvhjY8nb76VuHj3DIuqqhzuFQ==@sourceware.org X-Gm-Message-State: AOJu0YxWKgfYJqQO0FiMhjksvd4t46JN8YDr3nGwiSOo+Ui6MmxYDRzb lK1/VtPwpvnYkSECdSfrUa5wUYoGGEn6S9z0i/M1DoLb/XgUYFFWRjHZW9pHhIER2DYJCOx0C1Q uyzw= X-Gm-Gg: AZuq6aKX+v8zR5ye9+b8oEO3EcqZHvmYNcDmIo8zVdC221bGFYPP2gMZzeX5UwHdnwj 6cUtGS4AXM+jiCBHZIEB1i91bVqnNTakuG8pa0bZna8Tvfot6selwDKnNRHhJoLXYHvRRnJrTiz j2RGBGbmbeLe9dn/HGPTY5n/y3BLdjeTb2MKv8rVoPjd1NLcelyn7WJHUFJClBG/6Q8dr1w8BVM nSN0byxbqDyIETPgOaAy8vv1cZdF0vZJ9McaHHg57eFzmfnAruH6hjmOm+WLskqxa20Lt5GFX33 ct8s5Q/8RsWXjUsp2LZKVm70EQqNhD+lnnOE+jkz13uGIepCMTTxBFD3V9mCYtsoeaiyPyVNOdA w0Ih7bvcDxfkzkZ3ZQBHPnHWCQX9XVePv6lQufQ1vpQw3yUHrEoDO3TLg16Z8mBUIZppsTJvd2e z+7CpM/prgyrpOozh+a2GkSFu0O/VZgjYRdLSc+EfzsQaAww== X-Received: by 2002:a05:6870:8455:b0:3ec:4f31:42a with SMTP id 586e51a60fabf-4157abe7fb5mr3799904fac.7.1771849722491; Mon, 23 Feb 2026 04:28:42 -0800 (PST) Received: from bapiya (97-122-122-234.hlrn.qwest.net. [97.122.122.234]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4157cf9f666sm7218701fac.7.2026.02.23.04.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 04:28:42 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] Return gdbpy_ref<> from symtab_and_line_to_sal_object In-Reply-To: <9eed1009-8563-45cf-b9d2-e0ebb3005683@simark.ca> (Simon Marchi's message of "Fri, 20 Feb 2026 20:58:15 -0500") References: <20260220-python-safety-minor-v1-0-4c4b12e445af@adacore.com> <20260220-python-safety-minor-v1-1-4c4b12e445af@adacore.com> <9eed1009-8563-45cf-b9d2-e0ebb3005683@simark.ca> X-Attribution: Tom Date: Mon, 23 Feb 2026 05:28:41 -0700 Message-ID: <87tsv7zls6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> - return result; >> + return result.release (); Simon> In these cases I think I would return directly from the Simon> symtab_and_line_to_sal_object call: Simon> return symtab_and_line_to_sal_object (sal).release (); I made this change, except in one spot where it would negatively affect the formatting. Tom