From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cenACnPS7GmL4ToAWB0awg (envelope-from ) for ; Sat, 25 Apr 2026 10:40:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TFvDKOiT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 16A511E0BA; Sat, 25 Apr 2026 10:40:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4758A1E067 for ; Sat, 25 Apr 2026 10:40:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C3D894BB588A for ; Sat, 25 Apr 2026 14:40:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3D894BB588A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TFvDKOiT Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 34A1F4BB588A for ; Sat, 25 Apr 2026 14:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34A1F4BB588A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34A1F4BB588A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777128014; cv=none; b=DR4Y2kl9i+MiqSlPrQIUBmy11Wzwlk0K/X3TZVkfOSKiR/33rnYDkQE86BAy+9vk3BBmcDUJ1AyPB4olEOx72WliEVzzCJP7aWca8oJ0XIibzxO5qrdCyDr8ZbFb1sGllfAbVb1Y+5JRsAxDNzTlHlNhAv8WmXT6E4xTSWdvEfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777128014; c=relaxed/simple; bh=WWYOuLnEemw5nwK2qFsHyLWN/EKEAdENGL7jSYIGwLE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c4wxF3/O/rxcslnDdUubdANm/M5BLxQZVa0KC+GSfnISNcrZE+usP8C9NmMn0ylsyotCViM1jvXUqKDlx3bDPc9ZfXsPSGBUgKeHds+u2GP3KVLMvv7aqbiOxRjcLGam+rlWuGTGI76mv454++vTV0rd/v/4dfAo9mdpp2lisgk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34A1F4BB588A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777128013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ezx/E6tp0y/vS+8hUHLo4Hc12z1rJcTo0sJ9nXCeSQY=; b=TFvDKOiTM6GgxFIfJscZJKt1MiZNOZWBY8LQ9FxrYTFV+AJ1rMlqUQ7Izt6/K4JE8ZLhX0 z5G5jhM5sQqBmnoM0Zz4cC3EluoybKL7nZWwIjC2VPDKu1Fo0jEsbsDUU9px0ka5wbTmVY +XRhWFUbh3pqD9woJVYI+cW8VMRTW4c= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-CZ6E6AJ2PMq-jUG9LrtNpw-1; Sat, 25 Apr 2026 10:40:12 -0400 X-MC-Unique: CZ6E6AJ2PMq-jUG9LrtNpw-1 X-Mimecast-MFC-AGG-ID: CZ6E6AJ2PMq-jUG9LrtNpw_1777128011 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4411a529bc0so5051803f8f.0 for ; Sat, 25 Apr 2026 07:40:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777128011; x=1777732811; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ezx/E6tp0y/vS+8hUHLo4Hc12z1rJcTo0sJ9nXCeSQY=; b=SKoyfNL73z7OQEw36BAVEdcY3isyByMiKb/6pW06qb1+TWUvWao8mSwuedDOWz9CgE D2ZDZ09LjqDTJsrePx+TArUiVMSHY7w7VM+oNU0zSXYdL+a3bkkzhZUvCK2l41gVlZ7r bJPKQxlilSiGRG1WjnBhtfXch74JjQr3hLGgW7fv6bUG0Kz0cc3qW7y0lJdmqJJX+UnQ d4hsg5jVn6rivCPsbHY6q0ftJvFG6MtWmBKgEfCM/7xUBsRN+XP20bGdid4QvpD/Nnm1 q4f3Ip76Ga/24KXWOao1tE1oeujNqa3v7quyLt1pv6PxsHI+xuIasfTLYxvWIbcIWhXk XTwg== X-Forwarded-Encrypted: i=1; AFNElJ/Z+ltPViRhKxCGyWVP6NvnytOrAC+MBqSqfw+42tF7Jm8p2vjCHvTx1ll9leS2hNNs/jIiahaQ0Zx/jA==@sourceware.org X-Gm-Message-State: AOJu0YxpvsYkJVmFN0wHOVyzpPVIhXyc17Ty4xfHqvIhd8GwlincVOLi J6OMPlSfiPkquP+YJ9NFgZrIoNzfQT5OsYKk7X0uImooxntTioUd/yu/KOcBzx+G2aWpIEsIMQ3 7FDfw8PWv+fqte6P+lW6C7wHfQedAtMMfu3Q2/iRbDT3c3bsQdYnpByLXMYZtFJs= X-Gm-Gg: AeBDies/Bef7AwbPfnjjt2Vbg7Tm/eC2+xxeaR9TmkJuODJraUATA+0+mBZ4tmqBVcv 7A5UzxFloEVo9n8YJW5T8/VXqVB7XISA0tKk4vfZSSZcIC4ZIthJXpppF2tM5Th4nLHY3xyqMl6 xHZsQ4I2ps3Pq5jSHU1e1GV19LmZkVWR+jSk5FQZxh+knuET7AGDZjyjN2UhnCpo3RSXGvV5Cao o/c6EKDYr04i6omzJoSsI/rkoQsgnEAyxYSOwpqnbE5evvdbYWxArGK7AeGuCWISzvIiV8r/UJK 5kkpureeiW49mksRURrMNN9jQhLfNP20tq3slRKmV9w1V7k1kOq4/VbCwTl67UKDCGOZZ1Ixc0B lJqE2giKmvExh1avnTdmHwngcdk+wTLJGxTTw8yuZRGOZT/HsnJVTecv/ X-Received: by 2002:a05:600d:8451:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-488fb743c43mr437688055e9.11.1777128010824; Sat, 25 Apr 2026 07:40:10 -0700 (PDT) X-Received: by 2002:a05:600d:8451:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-488fb743c43mr437687825e9.11.1777128010292; Sat, 25 Apr 2026 07:40:10 -0700 (PDT) Received: from localhost (92.40.185.140.threembb.co.uk. [92.40.185.140]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc18bccfsm600011675e9.8.2026.04.25.07.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 07:40:09 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query In-Reply-To: <20260417075719.852558-1-tdevries@suse.de> References: <20260417075719.852558-1-tdevries@suse.de> Date: Sat, 25 Apr 2026 15:40:08 +0100 Message-ID: <87tssz14tz.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3uGfFsxHCI3VWxXh1RrYs1ffFumupEcKDMaNhAHf4pg_1777128011 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > This patch series fixes two PRs, PR31449 and PR33794. > > An initial patch for PR31449 was submitted here [1]. A review comment > reported a problem when using C-x C-a to enable TUI instead of "tui enable", > not fixed by the patch. This was filed as PR33794. > > The initial patch fixes PR31449 by calling a function that will force the > debuginfod query to happen before enabling the TUI. Hi Tom, Just FYI, I'm not forgotten this patch. I'm in the process of reviewing it, and will have some feedback next week. Thanks, Andrew > > Changes in v1 [2]: > - change approach: > - add a layout with only the command window, and activate that layout first, > making sure that we finalize the initialization of the command window > before we activate the initial layout > > Changes in v2 [3]: > - change approach: > - add a facility defer_tui_rerender that allows deferral of calling the > rerender methods (which draws everything but the window borders), and > - use that facility to postpone rerendering in tui_enable until after io has > been initialized. > > Changes in v3 [4]: > - change approach: > - add a check at the start of tui_inject_newline_into_command_window that > avoids the SIGFPE. > > Changes in v4 [5]: > - change approach: > - bail out if debuginfod enabled is set to ask when entering TUI. This is > very similar to [1]. Unlike the previous approaches, this does fix > PR33794 as well. > > Changes in v5 [6]: > - fixed some trivial errors in the v4. > - split the v4 patch up into three patches, > - added a patch introducing defaulted_query_auto_answers_p, > - used defaulted_query_auto_answers_p to make the fix less intrusive > > Changes in v6: > - committed first patch of v5, a refactor patch > - change approach: > - revert to v3 approach for PR31449. The error thrown in tui_enable also > affected "gdb -tui", and for that scenario could only be avoided with > "set debuginfod enabled on/off" in .gdbearlyinit. > - describe entire version history in series description, instead of partly in > the series description and partly in one of the patches > > Tested on x86_64-linux. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31449 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33794 > > [1] https://sourceware.org/pipermail/gdb-patches/2024-March/207224.html > [2] v1 https://sourceware.org/pipermail/gdb-patches/2026-January/224038.html > [3] v2 https://sourceware.org/pipermail/gdb-patches/2026-January/224103.html > [4] v3 https://sourceware.org/pipermail/gdb-patches/2026-February/225210.html > [5] v4 https://sourceware.org/pipermail/gdb-patches/2026-February/225351.html > [6] v5 https://sourceware.org/pipermail/gdb-patches/2026-March/226009.html > > Tom de Vries (4): > [gdb/tui] Fix crash with debuginfod query (tui enable) > [gdb] Add debuginfod_enabled_ask_p > [gdb] Add defaulted_query_auto_answers_p > [gdb/tui] Fix crash with debuginfod query (C-x C-a) > > gdb/debuginfod-support.c | 40 ++++++++++--- > gdb/debuginfod-support.h | 5 ++ > gdb/testsuite/gdb.tui/query-foo.c | 24 ++++++++ > gdb/testsuite/gdb.tui/query.exp | 98 +++++++++++++++++++++++++++++++ > gdb/tui/tui-io.c | 3 + > gdb/tui/tui.c | 10 +++- > gdb/tui/tui.h | 2 +- > gdb/utils.c | 55 +++++++++++++++-- > gdb/utils.h | 4 ++ > 9 files changed, 224 insertions(+), 17 deletions(-) > create mode 100644 gdb/testsuite/gdb.tui/query-foo.c > create mode 100644 gdb/testsuite/gdb.tui/query.exp > > > base-commit: 19bcbe810d8c49eb05324624c0af72091d38c4a7 > -- > 2.51.0