From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EZxTI+Mp8GlSyz8AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 23:30:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Ex5L161P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8BE051E0BA; Mon, 27 Apr 2026 23:30:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E2A771E093 for ; Mon, 27 Apr 2026 23:30:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 09C9E4B9DB58 for ; Tue, 28 Apr 2026 03:30:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 09C9E4B9DB58 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Ex5L161P Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by sourceware.org (Postfix) with ESMTPS id B58F14BAD14C for ; Tue, 28 Apr 2026 03:30:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B58F14BAD14C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B58F14BAD14C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777347008; cv=none; b=Bh2uUQrRBbigoy/ycMLbUSio0g5gGMCvpPYpBbo+2MaJ1zR0CfCiY+7vZVdexQdep4OTMmbQYZtMXQzUhoFfgYYRVJDo2i6QuP5v33Bh0vHLNJks0eje7rosW+hCVq1G/1eyM0REeii2iq6fiGmvb8mEn4RS65ltA2ERSdc+dec= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777347008; c=relaxed/simple; bh=deU0VcjFSHRdH52JMY90bp/CLe+GJeF5U0I0z9IunC0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Rj397k+l38ShXF903QXOo6wXc5IA0MoS4aUlenI2qwOfHBgSNIkHBgyuRvlGFAnt7hdgmBo3q8wHCG6otbdsE0iX7Zu4bvfJfvXIzDFhZsfdVd91XU9oDj8TsGUhIZc+vBghLtvu3tnbp+qy/0N7yRrgo/uVKdB4yyiUzkA4/hE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B58F14BAD14C Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-794719afcd4so114879077b3.1 for ; Mon, 27 Apr 2026 20:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777347008; x=1777951808; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4AB8U8qJE0SLqUiMDtwg9tZLRefKHWOySbSqyd1+VSk=; b=Ex5L161Pd39oZM/6uMFdDeA1e+Y0fInOZEG3nV+jbOfvFTl57VTH8HdZq1nIpUHZW6 y7QIg4XxJ49pWbPXOkWXXmUHqu/GRskN4W0XP98F9mVE22RoN16Gn2mSo8uMgi9p4fAY O2zpoRCoI6piSi+yN+JC9gDAyJjje6V4cJOwlRC3PNF6DhqPskpNcww98oKF2tSbJl4g jGNoGZorgb8uuHX2gJ6cmVkaVgPtdSE6APTDwLVXCWHyl3uUxkeGuecV7FSbOBypR3VI 4VhU8pB5Ny0VxFFnjuxIt6Ioc55pAbjQROQtHIoyZzasYg7MAlhqMS6QTtlua7NPB6vC 2bWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777347008; x=1777951808; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4AB8U8qJE0SLqUiMDtwg9tZLRefKHWOySbSqyd1+VSk=; b=IJTvLPTg/mk64FBwbUmffxNzvRBzJBH3YL2Xgi5hBHzpSIfVuQCjf/HNpPEPBVkhN0 5QvV8qqpQQXsmiLB1GgsavNgF8At4tCcqMxaKmCzeKPpf0DRLDKJs8eO8Uab4+DLKGxa TdBeXtAq7kt37oro8oWUcp0M01rmPeWYrSayS79zOWfbEvWnLtRzcJdwD6CCnyD7z4mB m8HUko9r0o3/9PjISez5m+DZB6CnrSaV2CJJycZOleIbiENaY9AWWRgFU01Qa3qEOyUx txSg7Z4sGanSaGuV6wZrWDP5uXiktXdJ2486c++4eVn7/GvU+oc4w/ZRAaLnMc3QyknT zhcQ== X-Gm-Message-State: AOJu0Yz0HR6s/L6C1l0/EH34BpdT1wsbrhEcdhsI1siFHw+XGRxpFIZ4 DPdXDhGWVBiU+amZfYOXPD8xnV5ZPIDJE0RZ7Gj9AqdfoefNfQdtbe56l1DGncLSv1Q= X-Gm-Gg: AeBDiev50CLbdFAFTrayzS330LeaV5/83kBk8sJ3xl8Zj7S1OLw/XcHOPextHYMiCkA wuVf8/uYjCNAudeSnXXelaBYIj6Sl/hlviv7wqWrvBNUukmhbNJj92nEMlHq/SphfLcC9sez907 GqV5HXFvZ/jCSs6FXvJPoHtKJ0FdlcIM5ViLB/C5sVt0aZfLV9omsj2SjEWAzkPBDNr0F5Qa5tL Hj4LWNBENkT1yIwBpJ6OgDKW/VkgiLoVnNUTWLtclA9d7+jfU1JdW3zI81XByCXz4UAAMywa7I6 cr2jZ1n5lN/zKBiUT1wb49VwDmfiZ5snTHoeEtFikjUtPOdJ44g0pgeOHXNpsQNGR3vrPi2obgp xcMCbczjZqkOtNziE02OBUQOBrCUWS2o6MPq+N/1nWEoICEP0UG/wiCl67C1YjVuETh5G3wyPBP NxBE2NWTMWLvOlI5i38kiboAmGhtm89tFSXR4k6AkYuqbd/5sqCFBO78g= X-Received: by 2002:a05:690c:3346:b0:7ba:ded4:df6d with SMTP id 00721157ae682-7bcf50e81dcmr11395787b3.19.1777347007929; Mon, 27 Apr 2026 20:30:07 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bcf0c0850esm8504217b3.36.2026.04.27.20.30.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 20:30:07 -0700 (PDT) From: Thiago Jung Bauermann To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 5/6] gdb/record: extract the PC to record_full_instruction In-Reply-To: <20260423152604.171356-6-guinevere@redhat.com> (Guinevere Larsen's message of "Thu, 23 Apr 2026 12:26:03 -0300") References: <20260423152604.171356-1-guinevere@redhat.com> <20260423152604.171356-6-guinevere@redhat.com> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Tue, 28 Apr 2026 00:30:05 -0300 Message-ID: <87tssvkbia.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > This commit makes it so the PC is not saved as part of the > record_full_instruction effects, but rather gets a special location. > That is because a couple of commands would really benefit from it being > easy to find the PC (especially ones from record-btrace that's haven't > been implemented to record-full yet, such as the ones in PR > record/18059), while also possibly allowing for one fewer resizing of > the effect vector (and saving an entire byte in the process). > > This commit also refactored record_full_read_entry_from_bfd and > record_full_write_entry_to_bfd, to make them methods of > record_full_reg_entry and record_full_mem_entry, and also creates > similar methods for record_full_entry and record_full_instruction. > These could be turned into constructors in a future step of > c++ification, but it felt like too much change for a single commit. > --- > gdb/record-full.c | 384 ++++++++++++++++++++++++++++------------------ > 1 file changed, 237 insertions(+), 147 deletions(-) Reviewed-by: Thiago Jung Bauermann -- Thiago