From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9RWnNQzX9GlrTQkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 12:38:36 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VLS9GiM9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C8ED41E067; Fri, 01 May 2026 12:38:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 530041E067 for ; Fri, 01 May 2026 12:38:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 76A3A46A9CC2 for ; Fri, 1 May 2026 16:38:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76A3A46A9CC2 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VLS9GiM9 Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 909DD4AA396C for ; Fri, 1 May 2026 16:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 909DD4AA396C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 909DD4AA396C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653491; cv=none; b=NOp/Wuu5AmoPSq5i1Muta2Wx7T+LlUHf69Wn2aPUtsz3M0zgfR0TmpB4cLijD2D81bEq0ZK/SnIYL4DB7AcXbZGQf0rjtGq5w3E0Y6a0A/lTRNatcmnQhawQjpVRmJlcOBKaQ+m4coEavJeKqDdRqO+CY6zlZOVH+kIJv8OJ4hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777653491; c=relaxed/simple; bh=UFhJ6SshwYBDhJVPgwE3jAboIu83uGJk+qIWlrH+JIw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kdm0QTb4lCN1e1JFmZGrhw0vO1VCJlTgnxGLMu5hGoJlaN6Dca3+gBKpYo4NsGOxNvC/KO/gtUfYytxoiPS5mulc2amcdW6z3kpfn5qIDgh1RT7u47sx/uo5k+4xmGM8IyufNJn/FItbAjQsOhlA6JPTL6g5+Zo2P1FoSUSntTU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 909DD4AA396C Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id IaMWw1wZUrDqVIqsUwWN5T; Fri, 01 May 2026 16:38:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id IqsTwFYOiw84vIqsUw7WrI; Fri, 01 May 2026 16:38:10 +0000 X-Authority-Analysis: v=2.4 cv=ZIbXmW7b c=1 sm=1 tr=0 ts=69f4d6f2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=zstS-IiYAAAA:8 a=sTITUv5SS8I5OwmecqYA:9 a=QEXdDO2ut3YA:10 a=vsCvvem9CHYA:10 a=6KDmPahKW5ILxopYhpMU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+ifW3hVfhMAP+cODCBWCl3M/0teghDa63gSjtSjoZ50=; b=VLS9GiM9RBR45N8jjCqbZuCtGJ w9lpRYUONATEnvdcZoOysxzo3+Iva3oiYbr6dqTT9xMJ+IOHWmujybBpdJiGE60p7h37x62K/aju4 r9qK2MlroOe5jHjdaZr8ytox4; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:46480 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIqsU-00000001JSt-0OWa; Fri, 01 May 2026 10:38:09 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Simplify tui_enable In-Reply-To: <20260429112818.1610891-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 29 Apr 2026 13:28:18 +0200") References: <20260429112818.1610891-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 01 May 2026 10:38:08 -0600 Message-ID: <87tssrgk5r.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wIqsU-00000001JSt-0OWa X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:46480 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfC0fBhtfkMpYTTXNt4b52KALC//mk+pUyUGs2dylBeMr+B7weVKC6/kNAYTfyeO09CVwz/VP87e5eyiBNg0MVKVSDIZg0vLApQvsXZRwR42zKgcyizTu k6OeXA3MPfGIQ5llGxqPVe0MbenOWP59lsusFomgQOznV0NEFmwMxWYifboMxYGzS3FNxT8mcv6DBBfckeXtkz8deXY0K3VlbeA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" =3D=3D Tom de Vries writes: Tom> I noticed some code in tui_enable doing: Tom> ... Tom> if (...) Tom> error (...); Tom> else if (...) Tom> ... Tom> which is the "Don=E2=80=99t use else after a return" anti-pattern [1]. Ok. Approved-By: Tom Tromey Tom