Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Lancelot SIX <Lancelot.Six@amd.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: fix 'exited' event when GDB exits from core file debugging
Date: Sat, 06 Jun 2026 18:35:16 +0100	[thread overview]
Message-ID: <87tsrfr2qz.fsf@redhat.com> (raw)
In-Reply-To: <b255ffa8-86e6-4eb4-94c5-5be7b5fe3057@amd.com>

Lancelot SIX <Lancelot.Six@amd.com> writes:

> Hi Andrew,
>
> Thanks for the quick turnaround!
>
> FYI, when applying the patch, git reports:
>
> ```
> Applying: gdb/python: fix 'exited' event when GDB exits from core file 
> debugging
> .git/rebase-apply/patch:127: indent with spaces.
>              "python print(str(gdb.selected_inferior()))" ""]
> .git/rebase-apply/patch:133: indent with spaces.
>             set inferior_string $expect_out(1,string)
> .git/rebase-apply/patch:134: indent with spaces.
>             incr event_count
> .git/rebase-apply/patch:135: indent with spaces.
>             exp_continue
> .git/rebase-apply/patch:139: indent with spaces.
>             verbose -log "GDB has now exited"
> warning: squelched 7 whitespace errors
> warning: 12 lines add whitespace errors.
> ```

This seems odd, I checked my local patch and I'm pretty sure that these
lines are using tabs then spaces, and the email I sent also appears to
be using tabs as far as I can tell.

I sent a V2 patch, if you are still seeing this issue there then please
let me know and I can try to figure out what's gone wrong.

>
> I expect you could have GDB create the coredump instead of relying on 
> the kernel for this.  This allows this test to run on systems where 
> kernel.core_pattern is not set in a way supported by the testsuite:
>

I took this advice for V2, thank you for the suggestion.

Thanks,
Andrew


  reply	other threads:[~2026-06-06 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 16:47 Andrew Burgess
2026-06-04 20:11 ` Lancelot SIX
2026-06-06 17:35   ` Andrew Burgess [this message]
2026-06-06 17:32 ` [PATCHv2] " Andrew Burgess
2026-06-09 10:19   ` [PATCHv3] " Andrew Burgess
2026-06-12 14:38     ` Pedro Alves
2026-06-14 21:06       ` Andrew Burgess
2026-06-12 13:49   ` [PATCHv2] " Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsrfr2qz.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=Lancelot.Six@amd.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox