From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qdmKORDkdWpG8xAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 09:56:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jQvb/pJw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E84C01E166; Fri, 07 Aug 2026 09:56:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 35F401E09B for ; Fri, 07 Aug 2026 09:56:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C45D34BA9021 for ; Fri, 7 Aug 2026 13:56:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C45D34BA9021 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jQvb/pJw Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id F06554BB3BF7 for ; Fri, 7 Aug 2026 13:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F06554BB3BF7 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F06554BB3BF7 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786110926; cv=none; b=wN7VG6dQn8pNuKjBbyqQiJxxBFhhslJrTawHNNwNczItFmyQ+FC3TkLdzPodmo7ur6065EaLtlc78tfHlPkZTQnctZTxHSK4Z+VHri7YQrNTUMx00dz/y8zgdtnWSj76doxRghJGCR4LWdPrF1Uh0NvGXMl4qy8RBfPjnFTi5Qk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786110926; c=relaxed/simple; bh=WNWWetEIyXLKMLXpKcX3/JAsPb7kHJYzJS9mJKLxQQg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vn8w7zwXYEIqMbvNsP58QLKabnmMTzLdFjb1RdBAssJ8QFmYKK32dzqnEydNn1Na5qD+RmHzdykVnyVMC6W90tMLunCPVAQ32qXU3qs9/HY8ebyOGBchYbMGeqq+F6JPXBoVf1L3ik4DFh2EkD5pGZAAoWBoaIHH0jDXTzuztLw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jQvb/pJw DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F06554BB3BF7 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7e9eaf04bfaso1292952a34.1 for ; Fri, 07 Aug 2026 06:55:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1786110925; x=1786715725; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=GdksbXzTKCe6cl0KX0HcuGQFxKeIsjxRg3G50Wq9rXk=; b=jQvb/pJwpKPF+xCIGFUyI2FxeRVJTtvcqxlb9tlsVgDcw/VPmlcFWb6JvZnzwt3Gct bp8lKCz/wgKnvtwRW3uZm1s4JQmuYZQLdEF5X0+/rKX4AfVkB+H1SzJ9HHxZRZUeNpVH Uc2XBFULHp65sbNthd2+9s1CS8b4mdLyJz0YFPWq7mdqTCn90CF1LjUtUkgsUBGz8GDq wtnMGTTbcFpAt8saWf9SEL0rhMdDSXLH8qJwnfUy3LhWMVamBqblmON5EoI0qoOUs0Q/ 1iv9FlPaYAWlOUWIlMg3OXrFwO3KG8LLaPxLL+H3pdu/TA53veAW/naaBdhcuwJF5nkd /n/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786110925; x=1786715725; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=GdksbXzTKCe6cl0KX0HcuGQFxKeIsjxRg3G50Wq9rXk=; b=KOupnq2RFqG8STAUSPg90S7VUFdZMiEzGEJrSkqGE3kBDUkL4rxN8pnvuSnhn9TsEd p1o/TEBsXc9y+gwQAiN6W+sCat4k15BxteCbmcqRFmaCaamSJyyj1X6L4qt0ExBUbj4b xRnCd78feN0H9NjaRVmBg9CxhbUXJVHjs7wAlkMnHDqb8KwmB3rj0Ajn9+UxajMgAbcB FRdJtrILfKGD1khr7i5D0Z+10/YV+tIniyiPOG7vyB1ieiQxKy3tKfNm2XFotOBqwvQY d5Nlfjz/Ee/FT8EihRCm2nFHd8qOB5b7yHNZ0uKNsfUp8GTnBlMWGrN6NQvPZblaB/40 /7Qw== X-Forwarded-Encrypted: i=1; AHgh+RqoopwvDl7ZhdHt9VC/7ikIqxO7Rw3NQ49aQ0VlJBF5r8rBfituHq1BCAB+bQuc/Vf+u/jXMauOwg8fZg==@sourceware.org X-Gm-Message-State: AOJu0YzpkPmKG4tXHwrmWOqql8beNfkCZ//0HXZsxESWVX7sKFAaZH8F AWfSnlBPCj5BihG1H5iFAEZZsKyhTUWni4XoiuPP1Z9bAIhn3KMpTkb1kK1dQOJ02g== X-Gm-Gg: AR+sD137lj7ks9UKjsDJd8QWZpCDFx6eYJlsqjYXM2rHF+n77wDblUNFFYxzRGwFzrn Wzg5wVR2v+2F9UDwZUSmvSfEItsx/dyGj+qNNSWOE72OodR/npm6HxVYC+D+AWxrJ6b4gdV0WRN Pq3Hl+ksImAo/HHQ2OxFoaUkVhNR+BqExWUw4I6yAGtsay9g7HlQrJv9gDNSrgJ51AMDYOWDy4R +mUf84ON9ke6wLyyEL6GrUbaZEra9fA/INiu8i4ESeqB4Om0J6CAmeYWMK8uGdwTgLE/yxFGTx+ SmMOEP0JO+tIe4009LK6OXmlrZfeTxssXEly7zQrzkYAAbJUFEzT0AR15cOcdswtBXgc8Vad11a aBE7+/LBz+aNAbC9vBnLkuNI8ktITS0khGovTxOPyEx/NtLgupKm16eGcE6bK7M/xePns+AVebC fxn8DbE9wkMgEqygFcqe7WbbVowLDU1ONnFkBPKnyEG6k9mGncYjhv6E86K6Uf3jpUqElgZSOG/ kun/QjA X-Received: by 2002:a05:6820:2909:b0:6ae:8ee4:e01f with SMTP id 006d021491bc7-6ae96c1003amr11795390eaf.4.1786110925311; Fri, 07 Aug 2026 06:55:25 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-459f15e43c2sm2152504fac.0.2026.08.07.06.55.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 06:55:25 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Always fetch Ada "main" name from the executable In-Reply-To: <87qzkclcm8.fsf@redhat.com> (Andrew Burgess's message of "Wed, 05 Aug 2026 18:07:43 +0100") References: <20260730170336.2547536-1-tromey@adacore.com> <87qzkclcm8.fsf@redhat.com> X-Attribution: Tom Date: Fri, 07 Aug 2026 07:55:23 -0600 Message-ID: <87tsp6xcfo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> gdb/ada: avoid rereading stale main name data in edge case Andrew> diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c Andrew> index 906c5cd3465..174e04af04c 100644 Andrew> --- a/gdb/ada-lang.c Andrew> +++ b/gdb/ada-lang.c Andrew> @@ -806,8 +806,7 @@ ada_main_name () Andrew> sections) Andrew> == TARGET_XFER_OK) Andrew> && xferred > 0 Andrew> - && (strnlen ((char *) main_program_name, sizeof (main_program_name)) Andrew> - < sizeof (main_program_name))) Andrew> + && (strnlen ((char *) main_program_name, xferred) < xferred)) Andrew> return (char *) main_program_name; Andrew> } Looks good to me. I suppose xferred < sizeof (main_program_name) and so the first strnlen is probably now redundant. However this doesn't really matter, the main name is not examined very often. Approved-By: Tom Tromey Tom