From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nYCdDG1GpGq0/AAAWB0awg (envelope-from ) for ; Fri, 11 Sep 2026 14:20:29 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FFDVFsW7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 111D61E033; Fri, 11 Sep 2026 14:20:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C567A1E033 for ; Fri, 11 Sep 2026 14:20:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D9754AA6FF5 for ; Fri, 11 Sep 2026 18:20:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D9754AA6FF5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FFDVFsW7 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 93CCB4BBC0F8 for ; Fri, 11 Sep 2026 18:20:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93CCB4BBC0F8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93CCB4BBC0F8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789150802; cv=none; b=UcV2FRMyuEP1gz/iTXyQhv6ZXK/+d/ny1+BMkm/QCIWIAIuJXvhbL1Hz8LqtSdiN+b853gL32H4NVVTjhhdaIw/LVX/SnhIN1oUrRl2Wf4KjWAunhBklwbzbFPO+OdAk5KUn2EOWgZik9G58fRTluSclctD+7K7xmD2x2Uc7atE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789150802; c=relaxed/simple; bh=rz5eaHLoNjpOnWfBIxhYpx9hJx5hjs8KKb1XmaXys3U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GKRKSxaHbxSd+nzsamr4DcFXoHI/2l84I2tPoP1CBox9njrYITHCy6emKptGZLDJbPowg5g9y7oK+jxXIJ1pie8VIOuk7o38LuSvzuyz2dRmty/qdSp3dXWQWtuD2OEfZf27BwZHfeCJgX9HsdRr4DIvIu7ZCtwfM+As/1Sg4Fw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FFDVFsW7 reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93CCB4BBC0F8 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id 4y39x7oJ6c3Xs55qzxhMj7; Fri, 11 Sep 2026 18:20:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 55qyx6dq0adLA55qzxwXD8; Fri, 11 Sep 2026 18:20:01 +0000 X-Authority-Analysis: v=2.4 cv=Aqzu3P9P c=1 sm=1 tr=0 ts=6aa44651 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=6EUWOSZodPf1P3L-J8cA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s6VaqnkMFrzNcK5Xe8QTeAJWqlfxEt/Ij/1U+dQHa+0=; b=FFDVFsW7jsCDYU4kTccIdSiuRA 3ASbRQm5awpca2xnbKrt11u4QnU/PKgp0YQrgCzOsLNgc0rbQVGqOUIhebcsT92VKkXeHRPAkPaks SPxkjDE18fV7NMVcOglvJmJaw; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:37014 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x55qy-00000001idY-14R7; Fri, 11 Sep 2026 12:20:00 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 4/7] [gdb] replace bsearch with std::lower_bound in find_pc_section In-Reply-To: <20260909094849.2745086-5-tdevries@suse.de> (Tom de Vries's message of "Wed, 9 Sep 2026 11:48:46 +0200") References: <20260909094849.2745086-1-tdevries@suse.de> <20260909094849.2745086-5-tdevries@suse.de> X-Attribution: Tom Date: Fri, 11 Sep 2026 12:19:59 -0600 Message-ID: <87tsnvy7jk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x55qy-00000001idY-14R7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:37014 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfADI9NCRi7PqgCCitWDqw4lCiaTErecGeiIv6BIW4UNKOB4xC9GZq+gw+IP7LWjDZ0CIMgimekUKR5rUvwjAawzkrITMosTVEgd1ZVcBSDuNU/roAxdp 6dCNHos77V4wNjjPW2srT+ypPaGW+LyqFuICUli9pVrnRCtW/hz7J0/ppLXqazM4zGZ9xHIkB0evDu3aez1LWznTqh1/jTg80Zw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> In find_pc_section, we use bsearch to find a matching section. This works Tom> fine, but in case the pc matches a section hole, it returns nullptr, with no Tom> information about where the section hole is. Tom> Instead, use std::lower_bound. Tom> + /* The std::lower_bound call returns the first section which is not ordered Tom> + before pc. That section may or may not contain pc. */ Tom> + if (it != data.cend () Tom> + && (*it)->addr () <= pc && pc < (*it)->endaddr ()) Could this use (*it)->contains? Tom