Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix MS_WIN64 redefinition error with Python >= 3.12 on MinGW
Date: Wed, 14 Oct 2026 05:57:29 -0600	[thread overview]
Message-ID: <87tsmo5wba.fsf@tromey.com> (raw)
In-Reply-To: <20261013140907.1346231-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 13 Oct 2026 10:08:56 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> Actually, since CPython commit 158b8a07212c ("gh-79218: Define
Simon> `MS_WIN64` macro for Mingw-w64 64bit on Windows (GH-100137)",
Simon> 2022-12-12), which is in Python 3.12, pyconfig.h does define this macro
Simon> when building with MinGW.  However, it defines it empty, whereas our
Simon> `-DMS_WIN64` defines it to 1, causing the macro redefinition error.
Simon> Change it to `-DMS_WIN64=`, which defines an empty macro, and avoids the
Simon> redefinition warning on Python >= 3.12.  Older Python versions still get
Simon> the macro they need.

Seems reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2026-10-14 11:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 14:08 Simon Marchi
2026-10-14 11:57 ` Tom Tromey [this message]
2026-10-14 12:52   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsmo5wba.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox