From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S2WGC3muz2pc3AkAWB0awg (envelope-from ) for ; Wed, 14 Oct 2026 12:31:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v1KKpziD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 171571E04E; Wed, 14 Oct 2026 12:31:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7EED41E04E for ; Wed, 14 Oct 2026 12:31:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 032FD4BA23D3 for ; Wed, 14 Oct 2026 16:31:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 032FD4BA23D3 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v1KKpziD Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 121004BA2E1D for ; Wed, 14 Oct 2026 16:31:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 121004BA2E1D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 121004BA2E1D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791995486; cv=none; b=lLmifwJk64yzMjDOOLAa8I0rH0gNQeS1LMenZu/bWoxeRLIS/Bml0+LicByBEVkdxZpfSqEdC4jciwhqB7EvR774t1tvlVfoS+SRXw/djWwRLgP0ISltBUc0Cg9EtlJcK4VryhQejuZzut1kYEyEtUKHTojCrNAmCfj0k87duiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791995486; c=relaxed/simple; bh=7n4kmeM/blmrVwYzXl4g4YhXLeJsRCQmWKCx6DUevHo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KPnk7RT3BC1en6RCZuGJC5Tu0T6Fj+cc196YaDY6sE+zvoZm4DrFfb3DYRiB0Jf1ru1tgMwShFTh2/pu3hBUjFsCNxH4nQ+taHijbmDcqRSpuuUj2Xa6SINEavikAZbkQwhmar/fnwv+yAlGpaiRGNaliZ+/YWaD/nEON/Uqg0M= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=v1KKpziD reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 121004BA2E1D Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id Gs20x2uq2v0ndH1syxdHps; Wed, 14 Oct 2026 16:31:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id H1swx1Vx1irxPH1sxxChpb; Wed, 14 Oct 2026 16:31:23 +0000 X-Authority-Analysis: v=2.4 cv=FqoF/3rq c=1 sm=1 tr=0 ts=6acfae5c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=zstS-IiYAAAA:8 a=mdh_DdMiMPdtT0ElHMIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pjQ76j0BhqPIOboFpDALJ5ZXYwnzt8sxviG6hFvMXDY=; b=v1KKpziD/DC1Au0ix5Apj+aCGv U3/xsIuFb+Jn8Z8Jy4BH7D8kJ72A7bn9s5YJMxS2koqNdd4KFxfviYPpjaPWgMFUElQx3Y6RdOzLX w4QrpZdtfeWm9hSNHO2ih0q7p; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:45562 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xH1sw-000000046eu-1Jch; Wed, 14 Oct 2026 10:31:22 -0600 From: Tom Tromey To: Stephan Rohr Cc: gdb-patches@sourceware.org, keiths@redhat.com Subject: Re: [PATCH v2 1/1] gdb: fix path expression for anonymous union members In-Reply-To: <20261009132139.37218-2-stephan.rohr@intel.com> (Stephan Rohr's message of "Fri, 9 Oct 2026 13:21:39 +0000") References: <20261009132139.37218-1-stephan.rohr@intel.com> <20261009132139.37218-2-stephan.rohr@intel.com> X-Attribution: Tom Date: Wed, 14 Oct 2026 10:31:21 -0600 Message-ID: <87tsmo2qhy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xH1sw-000000046eu-1Jch X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:45562 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJrXrFgoh7hoi5A8ADXVlrwOxRZztsDse6TbRNPxi4HToXoLmfpy7xjtjt1GbDCZNpTteOOq6brQ1LcxjZJ2NOSmUGI8Gn9EHQC9FGF2hZwMiXFcGbbm t/TcjoCAsjMlJP1A11tAiBI4P6CAGyt7N+yFRCHQmOTwkQgAgJGCpAh4E+Tq77YNUpOSyN8TGYvVCL4WCZ1gNh6/BErxAigdD78= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Stephan" == Stephan Rohr writes: Stephan> Extract the required logic from cplus_describe_child and use it to get Stephan> the correct index of the field within the parent type. With this change Stephan> the path expression is computed correctly: Stephan> interpret mi "-var-info-path-expression var1.public.1_anonymous.public.c" Stephan> ^done,path_expr="((s).c)" Looks good to me. Thank you for doing this. Approved-By: Tom Tromey Tom