From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NwMBJDcA2WqrewcAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 14:11:03 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=emCGPEWf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BC8451E051; Wed, 21 Oct 2026 14:11:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6DF931E04D for ; Wed, 21 Oct 2026 14:10:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C7AB4BA23DF for ; Wed, 21 Oct 2026 18:10:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9C7AB4BA23DF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=emCGPEWf Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 062444BA2E3F for ; Wed, 21 Oct 2026 18:10:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 062444BA2E3F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 062444BA2E3F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792606232; cv=none; b=ClixPiFQQCKrEznuhAvu4BUfjqKrph4uWhE4cClnWzBOOMDZp6sAHShyYdeqwO4hV6pIzzDcO4OKY3zk0171bpcIweGitJOmzm8ZaBjzZaFh+byPukz6q4Rcm8iCCVHq6GaIgxzTBdAUovOpDoBXvjfvXiZJFyqv+scEl+xNtR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792606232; c=relaxed/simple; bh=rRReS+/tn0RglJI7FT1//q6HoHLlA7tUgLUca+5j2VM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kzjk5CSs8JdLIlr4d24DGHYhpZ1nQCVQybQB104eUOmfpwo0hI+HUpPeVScXFLwLyiecN0IwnmJi+U5pGZ67wQ2wKpiydQHhkGYswkKaZ1qGt+EK+nxIFHKzYsWow30nMzEViJYcWrn90iWZBVXa0lbTBlFXcOBF1+bHiAqvQLU= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=emCGPEWf reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 062444BA2E3F Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id JREzxUhe5MylkJaljxPSGi; Wed, 21 Oct 2026 18:10:31 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JalixZ0dFouFZJaljxVbbm; Wed, 21 Oct 2026 18:10:31 +0000 X-Authority-Analysis: v=2.4 cv=Zd4dNtVA c=1 sm=1 tr=0 ts=6ad90017 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=pZT6vULojdOqFDNF06sA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dxo9b8N4Sy1SbMDaYVAH/3noW/FjhPFOfkP6Du+ZaMI=; b=emCGPEWfplJI/kDHtzmD0NgTtF WkaLLbbazk+k54eL1WARiZP4DrT5fN+cQf0xxV1uDqj3zmSLiKLGz6SDhiY7a5Kf2DEE4tWvYR2qN ZxU78itXh4FVyC7802vzBAtmX; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:50468 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJali-000000002pI-2D99; Wed, 21 Oct 2026 12:10:30 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/27] gdb.base/set-cwd.exp: Use is_windows_native_target In-Reply-To: <20260723130118.206735-11-pedro@palves.net> (Pedro Alves's message of "Thu, 23 Jul 2026 14:01:01 +0100") References: <20260723130118.206735-1-pedro@palves.net> <20260723130118.206735-11-pedro@palves.net> X-Attribution: Tom Date: Wed, 21 Oct 2026 12:10:29 -0600 Message-ID: <87tsmex6ui.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJali-000000002pI-2D99 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:50468 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLvtD67T1CXW2ne0+U0yNcqWCRls+YuxMmdgxLFoOUaPpYipnBa0n8vLdmzaKnRsEwDFJ1Mr91ntgMPI8qVBoN9PWyOfUEcs1xf3BTeDQgtTCCmbZyar 9X8B+mFH+fsAQJSbSqcwhb3P8w9FHxQS22/IRX7Wr7WlVSIvh6UtFEmNiU9ibILd2j1hixnhm8y7hylm5c6MmXaebfQPK+pOKXs= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> gdb.base/set-cwd.exp special-cases native Windows, where getcwd Pedro> returns a path with backslashes that has to be converted to forward Pedro> slashes before comparing against the expected directory. The check Pedro> guarding that conversion uses istarget "*-*-mingw*", which only Pedro> matches MinGW targets and misses windows-msvc targets, which are also Pedro> native Windows. Pedro> Fix it by using the is_windows_native_target helper instead. I guess this was renamed to is_windows_based_target? Anyway it seems fine with the fixup. Approved-By: Tom Tromey Tom