From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15057 invoked by alias); 8 May 2002 22:42:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15035 invoked from network); 8 May 2002 22:42:42 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 8 May 2002 22:42:42 -0000 Received: from creche.cygnus.com (ta0203.peakpeak.com [204.144.244.203]) by gash2.peakpeak.com (8.9.3/8.9.3) with ESMTP id QAA17914; Wed, 8 May 2002 16:42:38 -0600 Received: (from tromey@localhost) by creche.cygnus.com (8.9.3/8.9.3) id QAA18661; Wed, 8 May 2002 16:52:43 -0600 To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: Patch: printing java `char' values References: <877kmh8a6r.fsf@creche.redhat.com> <3CD8429E.DA6D6BC7@redhat.com> <873cx3vdhy.fsf@creche.redhat.com> <3CD9756D.F0AE4AF@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: I feel like I am sharing a ``CORN-DOG'' with NIKITA KHRUSCHEV.. Date: Wed, 08 May 2002 15:42:00 -0000 In-Reply-To: Michael Snyder's message of "Wed, 08 May 2002 11:58:53 -0700" Message-ID: <87sn52l0at.fsf@creche.redhat.com> X-SW-Source: 2002-05/txt/msg00238.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> I recommend that you emulate what C does, and whenever you Michael> have a TYPE_CODE_INT whose length is the length of a char Michael> (which for Java appears to be two bytes), you look at the Michael> type_name and see if it is "char" -- in which case you print Michael> it as a char. How does this look? Tom Index: ChangeLog from Tom Tromey * jv-valprint.c (java_val_print): Handle `char' as a special case of TYPE_CODE_INT. Index: jv-valprint.c =================================================================== RCS file: /cvs/src/src/gdb/jv-valprint.c,v retrieving revision 1.9 diff -u -r1.9 jv-valprint.c --- jv-valprint.c 21 Oct 2001 01:57:42 -0000 1.9 +++ jv-valprint.c 8 May 2002 22:41:22 -0000 @@ -497,20 +499,21 @@ return i; case TYPE_CODE_CHAR: - format = format ? format : output_format; - if (format) - print_scalar_formatted (valaddr, type, format, 0, stream); - else - LA_PRINT_CHAR ((int) unpack_long (type, valaddr), stream); - break; - case TYPE_CODE_INT: /* Can't just call c_val_print because that print bytes as C chars. */ format = format ? format : output_format; if (format) print_scalar_formatted (valaddr, type, format, 0, stream); else - val_print_type_code_int (type, valaddr, stream); + { + enum type_code code = TYPE_CODE (type); + if (code == TYPE_CODE_CHAR + || (code == TYPE_CODE_INT && TYPE_LENGTH (type) == 2 + && ! strcmp (TYPE_NAME (type), "char"))) + LA_PRINT_CHAR ((int) unpack_long (type, valaddr), stream); + else + val_print_type_code_int (type, valaddr, stream); + } break; case TYPE_CODE_STRUCT: