Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix PR breakpoints/13776
Date: Fri, 02 Mar 2012 17:39:00 -0000	[thread overview]
Message-ID: <87sjhqc37p.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F4E835A.5070102@redhat.com> (Pedro Alves's message of "Wed, 29	Feb 2012 19:58:18 +0000")

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> If you do this before exit_inferior, then the
Pedro> breakpoint_init_inferior change is wrong, because the
Pedro> clear_thread_inferior_resources will touch already released memory.

Ugh, thanks for noticing.
I should have tried this.

Pedro> WDTY?

I think the patch is fine.

Pedro> 2012-02-29  Tom Tromey  <tromey@redhat.com>
Pedro> 	    Pedro Alves  <palves@redhat.com>

... but it is silly to put my name on it since I think I wrote one line
in the result :)

Here is a test case for the bug.
I can commit it first if you'd prefer.

Tom

2012-03-02  Tom Tromey  <tromey@redhat.com>

	* gdb.base/nextoverexit.c: New file.
	* gdb.base/nextoverexit.exp: New file.

diff --git a/gdb/testsuite/gdb.base/nextoverexit.c b/gdb/testsuite/gdb.base/nextoverexit.c
new file mode 100644
index 0000000..125d68f
--- /dev/null
+++ b/gdb/testsuite/gdb.base/nextoverexit.c
@@ -0,0 +1,23 @@
+/* Copyright 2012 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <stdlib.h> 
+
+int
+main (void)
+{
+  exit (0);
+}
diff --git a/gdb/testsuite/gdb.base/nextoverexit.exp b/gdb/testsuite/gdb.base/nextoverexit.exp
new file mode 100644
index 0000000..fecbd58
--- /dev/null
+++ b/gdb/testsuite/gdb.base/nextoverexit.exp
@@ -0,0 +1,33 @@
+# Copyright 2012 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+set testfile "nextoverexit"
+set executable $testfile
+set srcfile $testfile.c
+set binfile $objdir/$subdir/$testfile
+
+if {[prepare_for_testing $testfile.exp $testfile $testfile.c]} {
+    return -1
+}
+
+if {![runto_main]} {
+    return -1
+}
+
+# Make sure we do not see any warnings.
+gdb_test_multiple "next" "next over exit" {
+    -re "$inferior_exited_re normally.\[\r\n\]+$gdb_prompt $" {
+	pass "next over exit"
+    }
+}


  reply	other threads:[~2012-03-02 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 17:51 Tom Tromey
2012-02-28 18:27 ` Tom Tromey
2012-02-28 20:35 ` Jan Kratochvil
2012-02-28 21:05 ` Doug Evans
2012-02-29 20:07 ` Pedro Alves
2012-03-02 17:39   ` Tom Tromey [this message]
2012-03-02 18:15     ` Doug Evans
2012-03-02 19:05     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjhqc37p.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox