From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Ensure result of make_cleanup is never NULL.
Date: Wed, 18 Apr 2012 14:38:00 -0000 [thread overview]
Message-ID: <87sjg1qf7o.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4F8ECE4F.1070004@redhat.com> (Pedro Alves's message of "Wed, 18 Apr 2012 15:23:11 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Well, aren't all places using the sentinel, using it throught the macro?
Pedro> What does this make more robust?
If you initialize the object it can end up in a read-only section, so
writes to it will SEGV.
In this particular case I don't see that this would help a lot, since
the object is just a sentinel. But, it wouldn't hurt and maybe it would
catch some really unusual bug.
Tom
next prev parent reply other threads:[~2012-04-18 14:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 5:01 Doug Evans
2012-04-16 10:58 ` Pedro Alves
2012-04-16 14:44 ` Joel Brobecker
2012-04-16 14:58 ` Jan Kratochvil
2012-04-16 15:03 ` Pedro Alves
2012-04-16 20:16 ` Tom Tromey
[not found] ` <CADPb22SfUk5s9JSSBvUTWVyhoiEqO4Gi+VNO-9MwH6rqW8qQ3g@mail.gmail.com>
2012-04-17 23:12 ` Doug Evans
2012-04-18 1:06 ` Doug Evans
2012-04-18 1:58 ` Joel Brobecker
2012-04-18 9:21 ` Pedro Alves
2012-04-18 9:29 ` Pedro Alves
2012-04-18 14:14 ` Doug Evans
2012-04-18 14:25 ` Pedro Alves
2012-04-18 14:32 ` Doug Evans
2012-04-18 14:36 ` Pedro Alves
2012-04-18 14:38 ` Tom Tromey [this message]
2012-04-19 19:24 ` Doug Evans
2012-04-18 9:26 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjg1qf7o.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox