From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29079 invoked by alias); 24 Apr 2012 17:42:52 -0000 Received: (qmail 29061 invoked by uid 22791); 24 Apr 2012 17:42:51 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Apr 2012 17:42:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHgX5R002049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Apr 2012 13:42:33 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3OHgVC2006200 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 24 Apr 2012 13:42:32 -0400 From: Tom Tromey To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [RFC/PATCH] Clean up unused variables (and prepare for `-Wunused-variable' flag) References: Date: Tue, 24 Apr 2012 17:49:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Mon, 23 Apr 2012 19:51:29 -0300") Message-ID: <87sjftdo1k.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00811.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> a) How's the ChangeLog for this patch supposed to be? Can I make a Sergio> "generic" ChangeLog, saying something like `Remove unused variables from Sergio> files'? I'm afraid I will leave that question for someone who cares a bit more. Sorry about that. Sergio> gdb/features/rs6000/powerpc-32.c | 1 - All these files are generated by some code in gdb/target-descriptions.c. gdb/features/Makefile uses 'maint print c-tdesc' to create them. So, you'll have to fix the generator instead. Tom