From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25631 invoked by alias); 9 May 2012 18:11:34 -0000 Received: (qmail 25488 invoked by uid 22791); 9 May 2012 18:11:32 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 May 2012 18:11:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q49IBHQ4016630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 May 2012 14:11:19 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q49IBF40014195 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 9 May 2012 14:11:16 -0400 From: Tom Tromey To: Giuseppe MONTALTO Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] new MI command for pattern filling of memory regions References: <76FE3225DF13124EA2D05B290B624C95E65F2D466E@SAFEX1MAIL1.st.com> Date: Wed, 09 May 2012 18:11:00 -0000 In-Reply-To: <76FE3225DF13124EA2D05B290B624C95E65F2D466E@SAFEX1MAIL1.st.com> (Giuseppe MONTALTO's message of "Wed, 9 May 2012 18:18:27 +0200") Message-ID: <87sjf9rzr0.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00294.txt.bz2 >>>>> "Giuseppe" == Giuseppe MONTALTO writes: Giuseppe> it's the first time I attempt a contribution to gdb, so feel Giuseppe> free to ask for details and, please, let me know if I'm doing Giuseppe> anything wrong! I was told off-list that you are covered by your employer's assignment. So, good. Giuseppe> the proposed enhancement is about memory filling. Giuseppe> Filling a memory region with a pattern of bytes so far, can Giuseppe> only be done by sending a potentially high number of repeated Giuseppe> commands to gdb (depending on the size of the region that we Giuseppe> need to fill). If gdb is controlled through a GUI Giuseppe> (e.g. Eclipse/CDT), this may cause the UI to freeze for a Giuseppe> quite long time. This is especially true when you're Giuseppe> debugging a remote target, due to the amount of generated Giuseppe> network traffic. I started to review this, but I wondered why a new command is necessary. It seems like you could send any hex string to want to -data-write-memory-bytes. Alternatively, if you really want the repeat count, why not just add an optional argument to -data-write-memory-bytes? That would seem to be simpler. Tom